Skip to content

Turkish translation chapter 0#54

Merged
lewtun merged 11 commits into
huggingface:mainfrom
akkasayaz:main
Apr 1, 2022
Merged

Turkish translation chapter 0#54
lewtun merged 11 commits into
huggingface:mainfrom
akkasayaz:main

Conversation

@akkasayaz

@akkasayaz akkasayaz commented Mar 29, 2022

Copy link
Copy Markdown
Contributor

English version was really smooth and I wanted the same for the Turkish version
#41

@akkasayaz akkasayaz changed the title Turkish translation Turkish translation chapter 0 Mar 29, 2022

@lewtun lewtun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great contribution @akkasayaz ! I've left a small comment about removing a file, but otherwise this looks great :)

@@ -0,0 +1,8 @@
# Default ignored files

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing this file from the PR and adding an .idea/ to the main .gitignore?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it can you check please?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks great - thanks!

@lewtun lewtun mentioned this pull request Mar 31, 2022
69 tasks
Comment thread chapters/tr/_toctree.yml Outdated
@@ -0,0 +1,4 @@
- title: 0. Setup

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to translate this title too if you want :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah :D I am not familiar with yml sorry never realized doing it

path_to_docs: course/chapters/
additional_args: --not_python_module
languages: en es th
languages: en es th tr

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI I added Turkish to the doc build so we can check it renders on the website :)

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Apr 1, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lewtun
lewtun merged commit 20b98de into huggingface:main Apr 1, 2022
GITbaburin pushed a commit to GITbaburin/course that referenced this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants