Skip to content

Add build step for Spanish content#39

Merged
lewtun merged 10 commits into
mainfrom
release-fixes
Mar 30, 2022
Merged

Add build step for Spanish content#39
lewtun merged 10 commits into
mainfrom
release-fixes

Conversation

@lewtun

@lewtun lewtun commented Mar 28, 2022

Copy link
Copy Markdown
Member

This PR adds a new build step to the PR / release CI to build the course content for Spanish.

Since each language lives in a separate chapters/LANG-ID folder, this seems like the simplest approach since we cannot easily build the content directly from the chapters directory (no global _toctree/yml file anymore).

An alternative would be to extend the path_to_docs arg in the doc-builder templates to be an array that one loops over, but maybe that can wait until we see there are too many languages to handle in the CI.

@lewtun
lewtun requested review from mishig25 and sgugger March 28, 2022 15:12
@lewtun

lewtun commented Mar 28, 2022

Copy link
Copy Markdown
Member Author

@mishig25 any idea why we cannot see the PR build? It seems one cannot reach the https://moon-ci-docs.huggingface.co/docs/course/ URL, but I'm not entirely sure if that's the cause of the problem 🤔

The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/course/pr_39). All of your documentation changes will be reflected on that endpoint.

@sgugger sgugger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first step. I was thinking of adding a language argument in the general job later on, for when we also build several docs in Transformers, but it might require a bit more work and I probably won't get to that until next week, so happy to go with this workflow in the meantime.

@lewtun

lewtun commented Mar 29, 2022

Copy link
Copy Markdown
Member Author

Oh, this approach doesn't work because we overwrite the content in each build step with

mv ../build_dir/${{ inputs.package }}/pr_${{ inputs.pr_number }} ${{ inputs.package }}/pr_${{ inputs.pr_number }}

i.e. the es content gets overwritten by the en build. I'm testing out multilingual support using this branch / commit on doc-builder: huggingface/doc-builder@d8215cd

If it works, I'll open a PR there :)

@lewtun

lewtun commented Mar 29, 2022

Copy link
Copy Markdown
Member Author

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Mar 29, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lewtun
lewtun merged commit b575f9c into main Mar 30, 2022
@lewtun
lewtun deleted the release-fixes branch March 30, 2022 12:47
GITbaburin pushed a commit to GITbaburin/course that referenced this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants