Add Japanese trasnlation of chapter 1 / 2 to 3#363
Conversation
|
Awesome work! 🤗 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
This is super cool ️🔥 I was thinking it could be nice to have examples in Japanese throughout the course, what do you think? Just a suggestion! |
lewtun
left a comment
lewtun
left a comment
There was a problem hiding this comment.
Thanks a lot for this great translation @blackdoor571 and welcome to the 🤗 community!
I think @fxmarty's idea to use Japanese models is nice, but probably best done directly in the notebooks to ensure the course content is 1-1 across languages. No need to do that yourself, but just making a note here for other translators :)
There's a small code styling issue with the PR - could you please install the requirements and run make style?
|
@lewtun Makes sense. Here's an example of how it was done in the French translation, with comments: https://huggingface.co/course/fr/chapter1/3?fw=pt . Honestly I'm not fan of putting comments everywhere (everything feels like less readable), but I see the point where there may be readers not able to grasp examples in English. I agree we could keep everything in English and leave translated example in future notebooks though. |
|
Hey @blackdoor571 thanks for this great translation! We just merged #359 which created some merge conflicts on the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
Thank you very much @blackdoor571 for your great contribution!! Merging |
Add Japanese trasnlation of chapter 1 / 2 to 3
6 participants
No description provided.