Skip to content

Add Japanese translation of chapter 1/4 to 6#360

Merged
younesbelkada merged 13 commits into
huggingface:mainfrom
haruki-N:main
Nov 10, 2022
Merged

Add Japanese translation of chapter 1/4 to 6#360
younesbelkada merged 13 commits into
huggingface:mainfrom
haruki-N:main

Conversation

@haruki-N

@haruki-N haruki-N commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

I created three files translated into Japanese: 4, 5, and 6.mdx of chapter1.

@younesbelkada

younesbelkada commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Thanks a lot for the great translation!
As you can see a small test is failing, could you make sure to update the _toctree.yml as following ;) (you can check also here)
Screenshot 2022-11-03 at 14 34 30

@ArthurZucker ArthurZucker left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤗 Great work! Thanks a lot 🇯🇵

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@younesbelkada younesbelkada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the great translation!
In terms of content, that looks great to me 🔥 ! As stated in #359 I am just waiting the moon-ci to be back, check the frontend results and we should be good to merge! 💪
Thanks a lot!

@lewtun

lewtun commented Nov 10, 2022

Copy link
Copy Markdown
Member

Hey @haruki-N thanks a lot for your translation 🤗 ! We just merged #359 which means there are some conflicts with the table of contents - would you mind resolving them and pushing again?

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@younesbelkada

Copy link
Copy Markdown
Contributor

hey @haruki-N , I have addressed the issue!
Thanks again for the amazing contribution !!

@younesbelkada
younesbelkada merged commit eeab1f0 into huggingface:main Nov 10, 2022
GITbaburin pushed a commit to GITbaburin/course that referenced this pull request May 17, 2026
Add Japanese translation of chapter 1/4 to 6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants