Skip to content

Update notebook links#312

Merged
lewtun merged 3 commits into
mainfrom
update-nbs-links
Sep 13, 2022
Merged

Update notebook links#312
lewtun merged 3 commits into
mainfrom
update-nbs-links

Conversation

@lewtun

@lewtun lewtun commented Sep 13, 2022

Copy link
Copy Markdown
Member

This PR updates the Colab / SageMaker URLs to point to the course/en folder in the notebooks repo: https://github.com/huggingface/notebooks/tree/main/course/en

The default behaviour is to render all notebooks in English - community contributors can add a course/LANG-iD folder to the notebooks repo and update the URLs when needed

Edit: the default behaviour is to now generate all the notebooks in one go, directly from each language

cc @lbourdois @mishig25

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Sep 13, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lewtun

lewtun commented Sep 13, 2022

Copy link
Copy Markdown
Member Author

Actually, on second thought I think I can already generate the notebooks per language to save the community this step. Will update this PR when it's ready

@lewtun

lewtun commented Sep 13, 2022

Copy link
Copy Markdown
Member Author

OK the new URLs look good and point to the correct notebooks per language 🥳

Screen Shot 2022-09-13 at 14 27 55

Screen Shot 2022-09-13 at 14 27 51

Screen Shot 2022-09-13 at 14 26 50

Screen Shot 2022-09-13 at 14 26 46

@lewtun
lewtun merged commit 796f41d into main Sep 13, 2022
@lewtun
lewtun deleted the update-nbs-links branch September 13, 2022 12:29
GITbaburin pushed a commit to GITbaburin/course that referenced this pull request May 17, 2026
* Update URLs to per language
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants