Skip to content

Italian translation: Chapter 3#283

Merged
lewtun merged 22 commits into
huggingface:mainfrom
sharkovsky:main
Sep 2, 2022
Merged

Italian translation: Chapter 3#283
lewtun merged 22 commits into
huggingface:mainfrom
sharkovsky:main

Conversation

@sharkovsky

@sharkovsky sharkovsky commented Jul 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Italian translation of chapter 3, as per #45

@sharkovsky sharkovsky mentioned this pull request Jul 18, 2022
Open
69 tasks
@sharkovsky

sharkovsky commented Jul 18, 2022

Copy link
Copy Markdown
Contributor Author

@lewtun I am getting some issues with building the docs that I can't figure out. Can you help me out with this "Unexpected token" error?
Thank you!

@sharkovsky

sharkovsky commented Jul 19, 2022

Copy link
Copy Markdown
Contributor Author

@lewtun the situation is made more complex by the fact that I am unable to reproduce the error locally, since the docs build without issue :(

lewtun
lewtun approved these changes Jul 25, 2022
View reviewed changes

@lewtun lewtun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this epic translation @sharkovsky and welcome to the 🤗 community! I think the error was coming from an extra line in the quiz, so I've fixed that and will merge once the CI is green - thanks again!

@sharkovsky

sharkovsky commented Jul 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thank you @lewtun! It's been a lot of fun to translate chapter 3 :)

And sorry about the extra line, in hindsight I guess the "Unexpected token" error message was quite clear... But I would have never figured it out without your help!

EdAbati
EdAbati reviewed Jul 25, 2022
View reviewed changes

@EdAbati EdAbati left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I had a look at this. It looks good :)
I mainly found some typos, potential small formatting issues and some of your personal comments that you left in some points.

I have also added some minor suggestions on how to change certain translation. Feel free to skip these if you don't agree.

:)

Comment thread chapters/it/chapter3/1.mdx Outdated
Comment thread chapters/it/chapter3/1.mdx Outdated
Comment thread chapters/it/chapter3/2.mdx Outdated
Comment thread chapters/it/chapter3/2.mdx Outdated
Comment thread chapters/it/chapter3/2.mdx Outdated
Comment thread chapters/it/chapter3/6.mdx Outdated
Comment thread chapters/it/chapter3/6.mdx Outdated
Comment thread chapters/it/chapter3/6.mdx
Comment thread chapters/it/chapter3/6.mdx Outdated
Comment thread chapters/it/chapter3/6.mdx
@sharkovsky sharkovsky changed the title Italian translation: Chapter 3 WIP: talian translation: Chapter 3 Jul 25, 2022
@sharkovsky

sharkovsky commented Jul 25, 2022

Copy link
Copy Markdown
Contributor Author

Thank you for the great review @EdAbati !

@lewtun I've marked the PR as WIP in the hope that it won't be merged, please give me a couple of days to implement @EdAbati suggestions. I'll ping you when it's ready again.

Thank you again!

@lewtun

lewtun commented Jul 25, 2022

Copy link
Copy Markdown
Member

@lewtun I've marked the PR as WIP in the hope that it won't be merged, please give me a couple of days to implement @EdAbati suggestions. I'll ping you when it's ready again.

Sure! Maybe ping @lvwerra when you're as I'll be on vacation for the next couple of weeks :)

@lewtun

lewtun commented Aug 15, 2022

Copy link
Copy Markdown
Member

Hey @sharkovsky - I'm back from vacation, so happy to review this again whenever you're ready :)

@sharkovsky

sharkovsky commented Aug 16, 2022

Copy link
Copy Markdown
Contributor Author

Thank you @lewtun ! Please give me a couple more weeks as I'm currently on vacation , and unfortunately I haven't had a chance to implement @EdAbati 's suggestions !

@lewtun

lewtun commented Aug 22, 2022

Copy link
Copy Markdown
Member

Thank you @lewtun ! Please give me a couple more weeks as I'm currently on vacation , and unfortunately I haven't had a chance to implement @EdAbati 's suggestions !

No rush - enjoy your vacation 🤗

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Aug 28, 2022 •
edited
Loading

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@sharkovsky

sharkovsky commented Aug 28, 2022

Copy link
Copy Markdown
Contributor Author

Hi @lewtun, I have implemented @EdAbati 's suggestions. (By the way, I had not realized what an epic re-reading effort you had made. Kudos for your attention to detail and thank you so much!)

On my end everything would be ready, but I see I'm failing an automatic check (not sure why). Maybe you could help me sort this out?

Thanks!

@lewtun

lewtun commented Sep 2, 2022

Copy link
Copy Markdown
Member

On my end everything would be ready, but I see I'm failing an automatic check (not sure why). Maybe you could help me sort this out?

Awesome work with integrating all the suggestions @sharkovsky ! I just ran make style to fix some code formatting and this should be good to merge once the CI is green

Thank you again!

@lewtun lewtun changed the title WIP: talian translation: Chapter 3 Italian translation: Chapter 3 Sep 2, 2022
@lewtun
lewtun merged commit 8f1ba9a into huggingface:main Sep 2, 2022
@sharkovsky

sharkovsky commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

@lewtun sorry to bother you, I noticed my name is missing from italian translators in the front-page README.md .... Is this intended?
Thank you!

GITbaburin pushed a commit to GITbaburin/course that referenced this pull request May 17, 2026
@sharkovsky
Italian translation: Chapter 3 (huggingface#283)
967ad9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lewtun lewtun lewtun approved these changes
+1 more reviewer
@EdAbati EdAbati EdAbati left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sharkovsky @lewtun @HuggingFaceDocBuilderDev @EdAbati