Translate ja event by trtd56 · Pull Request #241 · huggingface/course

trtd56 · 2022-06-11T01:08:34Z

Hi @lewtun @hiromu166
In this PR, I translate event/1.mdx.

This is my first-time pull request. If there is some mistakes, please tell me.

HuggingFaceDocBuilderDev · 2022-06-11T19:44:12Z

The documentation is not available anymore as the PR was closed or merged.

hiromu166 · 2022-06-13T23:56:47Z

Hi, @trtd56.
Thank you for translating event/1.mdx. I'll review this PR soon.
By the way, could you set Reviewers in the upper right corner? You can request review here.

https://docs.github.com/ja/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review

trtd56 · 2022-06-14T20:44:49Z

Hi, @hiromu166.

Sorry, I can't seem to assign a reviewer.
No gear mark for settings.

Is this note which you linked to relevant?

メモ: プルリクエスト作成者は、リポジトリ オーナー、またはリポジトリへの書き込みアクセス権を持つコラボレーターのどちらかでなければ、レビューをリクエストすることはできません。

lewtun

Thank you so much for this translation @trtd56 and welcome to the Hugging Face ecosystem! It's really cool that this is your first pull request 🤗

I left a few minor comments about the translation, but otherwise this is looking really good to me!

lewtun · 2022-06-17T06:27:35Z

+- title: Hugging Faceコースのイベント
+  sections:
+  - local: event/1
+    title: Chapter2公開記念イベント


It's been some time since I studied Japanese, but in the English version we refer to this as "Part 2 Release Event", so should the translation be something like

第2部発売記念イベント

I'm just asking why you chose to replace "Part 2" with "Chapter 2" :) Just FYI we use "Part 2" to refer to chapters 4-8

I second @lewtun's comments , to make it consistent with the other PR (#244) I think you should put パート2 and not Chapter2

Thanks for the confirmation.

「パート2公開記念イベント」
is a good idea?

I had thought Part2 mean is this repository's chapter2.
However, I should put PART2 to make it consistent with PR (#244) as @younesbelkada said.

And, I think "Release" should be translated to "公開" because I predict this "Release" means "publish".
"発売" means "sale".

Perfect thank you very much! Agreed with you

"パート2公開記念イベント" sounds good to me too!

I fixed in 6075579

Thanks!

lewtun · 2022-06-17T06:28:08Z

@@ -0,0 +1,204 @@
+# Chapter2公開記念イベント


Similar comment as above

I fixed in 6075579

Thanks!

lewtun · 2022-06-17T06:30:46Z

@@ -0,0 +1,204 @@
+# Chapter2公開記念イベント
+
+Chapter 2のコース公開後、Chapter 3のFine-tuningのコースの前に、2日間のトークライブイベントが開催されました。


Maybe we can use "Part 2" and "fine-tuning workshop" instead of "Chapter 2" and "Chapter 3"?

You're right.

The reason I translated it this way is that I thought "a fine-tuning sprint" would not correspond after part 2. (It should be part 3 after part 2).

But I thought I should be faithful to the original text, so I will translate it as:
「パート2のコース公開後、Fine-tuningのスプリントの前に、2日間のトークライブイベントが開催されました。」

What do you think?

Yes agreed with @trtd56 ! ;)

Yes, your new proposal looks great to me!

I fixed it in a5887ee

hiromu166

Thank you for translating!
This looks almost perfect for me.

hiromu166 · 2022-06-17T15:03:35Z

+彼女の研究は、アッシュ・カーター国防長官や米国盲人財団から表彰され、複数のテクノロジー企業で導入されています。
+ちなみに彼女はガーデニングと犬、猫が好きです。
+
+**Matthew Watson and Chen Qian:** *Keraによる自然言語処理のワークフロー*


Keraによる -> Kerasによる

I fixed in c4d530b

Thanks!

trtd56 · 2022-06-20T12:48:18Z

@lewtun @hiromu166 @younesbelkada @HiromuHota

I corrected the points that were pointed out.
Please review again.

younesbelkada · 2022-06-20T13:17:56Z

Hi @trtd56 ! Looks very good to me :) thanks for the corrections

lewtun

trtd56 added 6 commits June 11, 2022 07:17

Translate to Japanese (event Day 1)

2490c68

Translate to Japanese (event Day 2)

57c4e2f

fix comma

1cbaa72

fix: words and word order

f8506c9

fix YouTube link

b4bca33

add event to toctree.yaml

8d36105

trtd56 marked this pull request as draft June 14, 2022 20:33

trtd56 marked this pull request as ready for review June 14, 2022 20:33

lewtun reviewed Jun 17, 2022

View reviewed changes

younesbelkada mentioned this pull request Jun 17, 2022

Japanese chapter 4 #244

Merged

7 tasks

hiromu166 reviewed Jun 17, 2022

View reviewed changes

HiromuHota mentioned this pull request Jun 19, 2022

Translate JP chapter 8 #249

Merged

7 tasks

trtd56 added 3 commits June 19, 2022 15:36

fix typo

c4d530b

fix: Chapter to 'パート'

6075579

faithful to the original text

a5887ee

lewtun approved these changes Jun 20, 2022

View reviewed changes

		@@ -0,0 +1,204 @@
		# Chapter2公開記念イベント

		Chapter 2のコース公開後、Chapter 3のFine-tuningのコースの前に、2日間のトークライブイベントが開催されました。

Uh oh!

Conversation

trtd56 commented Jun 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HuggingFaceDocBuilderDev commented Jun 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hiromu166 commented Jun 13, 2022

Uh oh!

trtd56 commented Jun 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lewtun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

younesbelkada Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hiromu166 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trtd56 Jun 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trtd56 commented Jun 20, 2022

Uh oh!

younesbelkada commented Jun 20, 2022

Uh oh!

lewtun left a comment

trtd56 commented Jun 11, 2022 •

edited

Loading

HuggingFaceDocBuilderDev commented Jun 11, 2022 •

edited

Loading

trtd56 commented Jun 14, 2022 •

edited

Loading

younesbelkada Jun 17, 2022 •

edited

Loading

trtd56 Jun 19, 2022 •

edited

Loading