Skip to content

Chinese - Chapter 3finished#219

Merged
lewtun merged 38 commits into
huggingface:mainfrom
yaoqih:main
May 30, 2022
Merged

Chinese - Chapter 3finished#219
lewtun merged 38 commits into
huggingface:mainfrom
yaoqih:main

Conversation

@yaoqih

@yaoqih yaoqih commented May 26, 2022

Copy link
Copy Markdown
Contributor

Hello, we have finished the translation of chapter 3, please check. Among them, sections 3,6 of the chapter 2 were completed by @petrichor1122 , sections 1, 4, 5 of the chapter 2 were completed by @zhlhyx , section 2 and 3_tf of the chapter 2 were completed by me.

yaoqih and others added 27 commits April 12, 2022 00:53
 Add zh to the languages field in the build_documentation.yml and build_pr_documentation.yml files
Remove all these sections that haven't been translated yet
Remove Chapter 0 from the table of contents since it hasn't been translated yet
Fixed an error in the translation format of Chapter 1, Section 3
·Fixed some formatting errors
·Moved Chapters 0 and 2 to Simplified Chinese
Formatting revisions and some translation corrections
@yaoqih yaoqih changed the title Chinese - Chapter 0,2finished Chinese - Chapter 3finished May 26, 2022
@lewtun

lewtun commented May 27, 2022

Copy link
Copy Markdown
Member

Hey @1375626371 thanks for the latest batch of translations! It seems the code formatter needs to be run with:

make style

Would you mind doing that and pushing again?

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented May 28, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@yaoqih

yaoqih commented May 28, 2022

Copy link
Copy Markdown
Contributor Author

Hey @1375626371 thanks for the latest batch of translations! It seems the code formatter needs to be run with:

make style

Would you mind doing that and pushing again?

Of course, but I still can't pass the quality check after run make style. What should I do?

@lewtun

lewtun commented May 30, 2022

Copy link
Copy Markdown
Member

Of course, but I still can't pass the quality check after run make style. What should I do?

I've pushed a fix by:

  • Running make style
  • Committing the formatted files

It's a bit strange that various files unrelated to your PR are changed - my best guess is that the Git commit history on your fork is somehow out of sync with the main repo. To test that could you try running the following:

git fetch upstream
git checkout main
git rebase upstream/main

I'll check the format changes, but if it all looks good I'll go ahead and merge this - thanks for the translation!!

@lewtun
lewtun merged commit 2302e48 into huggingface:main May 30, 2022
@yaoqih

yaoqih commented May 31, 2022

Copy link
Copy Markdown
Contributor Author

Of course, but I still can't pass the quality check after run make style. What should I do?

I've pushed a fix by:

  • Running make style
  • Committing the formatted files

It's a bit strange that various files unrelated to your PR are changed - my best guess is that the Git commit history on your fork is somehow out of sync with the main repo. To test that could you try running the following:

git fetch upstream
git checkout main
git rebase upstream/main

I'll check the format changes, but if it all looks good I'll go ahead and merge this - thanks for the translation!!

Ok Thank you for suggestion. I'll try to do that before the next commit

lewtun added a commit that referenced this pull request Jul 26, 2022
* Chapter 2 Section 1 Bengali Translation (#72) (#168)

* [TH] Chapter 6 Section 1 and 2 (#171)

Co-authored-by: Suteera <[email protected]>

* [FA] CH1 / P1-2 (#142)

* Spanish Chapter 3: sections 1 & 2 (#162)

* fix typos in bpe, wordpiece, unigram (#166)

* [FR] French Review (#186)

* Part 7: Training a causal... fixes (#179)

* typo & error mitigation

* consistency

* Trainer.predict() returns 3 fields

* ran make style

* [TR] Translated Chapter 1.6 🤗 (#185)

* added chapter 1/6 to _toctree.yml

* [TR] Translated Chapter 1.6 🤗

* [PT][Chapter 01 - 2.mdx] - issue #51 (#170)

* Fix Gradio ToC (#193)

* Add Gradio authors and Blocks event (#189)

* Update 6.mdx (#188)

Correct link to Transformer XL doc

* Add translating notes and glossary to Spanish (#192)

* Add translating notes and glosary to Spanish

* Adding glossary to the toc

* add pt 4.3 (#191)

* [FR] Visual corrections (#190)

* [PT] add chapter 4.4 and 4.5 (#196)

* fix invite discord link (#197)

* [FA] Second draft of CH2/P1-2 (#139)

* added chapter3 in hindi (#198)

* [TR] Chapter 3/1 (#165)

* [RU] Ch3-1/2/3 (#200)

* [PT] add 5.1 and 5.2 (#204)

* [FA] - Ch3 - P1 and P2 (#199)

* [PT] add `end-of-chapter quiz` for chapter 4 (4.6) (#201)


Co-authored-by: lewtun <[email protected]>

* Chapter1: 2.mdx Translated. (#206)

* Remove comments from Persian ToC (#210)

* Fix CI URL for PRs (#211)

* code fragment & english syntax and meaning (#203)

* Updated Ch1/1 with Emoji (#214)

* Add missing numpy import (#217)

* [ES] translate sections 8.1 and 8.2 (#215)

* Fix path to datasets (#216)

* [PT] add 5.3 (#218)

* fix 4.3 (#223)

* Fix notebook generation (#227)

* Add Gradio nb links

* add 5.4 (#226)

* add pt wip (#225)

* Added Gujarati List. (#221)

* Add Gradio nbs links to fr (#228)

* Chinese - Chapter 3finished (#219)

* add ch7 at _toctree and translate 7.1 (#222)

* add 5.5 (#235)

* [FR] Review of chapter 7 (#233)

* Italian translation - chapter 4 (#230)

* Added Thai translation of chapters 3 (#231)

* [Ru] Add part 2, chapter 2 (#234)

* Update 8.mdx (#237)

- Remove Gradio Blocks Party
- Add, Where to next? section

* Created HI/Chapter1/5.mdx (#232)

* Add Spanish chaper3/section4, update toc and glossary (#238)

* [RU] Chapter 3 finished (#239)

* [PT] add 5.6 and 5.7 (#240)

* [EN] Visual corrections (#245)

* Translation for 1/4, 1/5 and 1/6. (#247)

* add event in PT (#250)

* Pin version of black (#252)

* Translate ja event (#241)

* [PT] add quiz chapter 5 (#243)

* Update 5.mdx (#253)

inconsistent naming with line 327

* Translation for Traditional Chinese (zh-tw) chapter0  (#251)


Co-authored-by: Lewis Tunstall <[email protected]>

* Translated the whole Chapter 3 to Thai  (#255)

* Japanese chapter 4 (#244)

* Translation of 1/7, 1/8, and 1/9. (#263)

* [PT] add chapter  8.1 and 8.2 (#265)

* [RU] Chapter 4  (#269)

* Add Thai translation for chapter 6.3b to 6.10 (#268)

* add 8.3 (#266)

* 3.mdx of chapter 01 (#260)

Co-authored-by: Lewis Tunstall <[email protected]>

* Fix typo (#271)

* [PT] add chapter 6.1 (#273)

* add Japanese chapter7 (#267)

* replace `load_metric` with `evaluate.load` (#285)

* update `load_metric` refs to `evaluate.load`

Co-authored-by: lewtun <[email protected]>

* [GJ] Translation to Gujarati - Ch0 Setup (#287)

* [PT] add chapter 6.2 and 6.3 (#279)

* zh-CN - Chapter 4,5finished (#281)

Co-authored-by: Lewis Tunstall <[email protected]>

* Chapter 01 - Done [PT] #51 (#280)

Co-authored-by: Lewis Tunstall <[email protected]>

Co-authored-by: Avishek Das <[email protected]>
Co-authored-by: Suteera  Seeha <[email protected]>
Co-authored-by: Suteera <[email protected]>
Co-authored-by: Saeed Choobani <[email protected]>
Co-authored-by: Fermin Ordaz <[email protected]>
Co-authored-by: Kerem Turgutlu <[email protected]>
Co-authored-by: lbourdois <[email protected]>
Co-authored-by: Sebastian Sosa <[email protected]>
Co-authored-by: tanersekmen <[email protected]>
Co-authored-by: Victor Costa <[email protected]>
Co-authored-by: Camille Couturier <[email protected]>
Co-authored-by: João Gustavo A. Amorim <[email protected]>
Co-authored-by: Bahram Shamshiri <[email protected]>
Co-authored-by: Kavya <[email protected]>
Co-authored-by: Batuhan Ayhan <[email protected]>
Co-authored-by: Pavel <[email protected]>
Co-authored-by: Kambiz Ghoorchian <[email protected]>
Co-authored-by: Vedant Pandya <[email protected]>
Co-authored-by: Diego Vargas <[email protected]>
Co-authored-by: Thomas O'Brien <[email protected]>
Co-authored-by: Lincoln V Schreiber <[email protected]>
Co-authored-by: 1375626371 <[email protected]>
Co-authored-by: Giorgio Severi <[email protected]>
Co-authored-by: svv73 <[email protected]>
Co-authored-by: Ömer Faruk Özdemir <[email protected]>
Co-authored-by: Caterina Bonan <[email protected]>
Co-authored-by: Hiromu Hota <[email protected]>
Co-authored-by: trtd56 <[email protected]>
Co-authored-by: Mehrdad Nezamdoost <[email protected]>
Co-authored-by: Wolvz <[email protected]>
Co-authored-by: a-krirk <[email protected]>
Co-authored-by: atgctg <[email protected]>
Co-authored-by: Thiago Medeiros <[email protected]>
Co-authored-by: webbigdata-jp <[email protected]>
Co-authored-by: Leandro von Werra <[email protected]>
Co-authored-by: Bhadresh Savani <[email protected]>