Skip to content

Fix links to new course demos + remove dark mode links#178

Merged
dawoodkhan82 merged 4 commits into
mainfrom
dawood/course-demo-fixes
May 16, 2022
Merged

Fix links to new course demos + remove dark mode links#178
dawoodkhan82 merged 4 commits into
mainfrom
dawood/course-demo-fixes

Conversation

@dawoodkhan82

@dawoodkhan82 dawoodkhan82 commented May 13, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented May 13, 2022 •
edited
Loading

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

lewtun
lewtun approved these changes May 16, 2022
View reviewed changes

@lewtun lewtun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these links @dawoodkhan82 🔥 !

Feel free to merge when you're ready :)

@lewtun

lewtun commented May 16, 2022

Copy link
Copy Markdown
Member

FYI the build on hf.co gives 400 errors for some of the Chapter 9 demos:

Screen Shot 2022-05-16 at 11 53 50

I checked the new URL for the sketch recognition demo and it still doesn't seem to work: https://hf.space/gradioiframe/course-demos/draw2/+

Can you please check that these URLs are correct? Maybe the draw2 Space still needs to be migrated to course-demos?

@dawoodkhan82

dawoodkhan82 commented May 16, 2022

Copy link
Copy Markdown
Contributor Author

FYI the build on hf.co gives 400 errors for some of the Chapter 9 demos:

Screen Shot 2022-05-16 at 11 53 50

I checked the new URL for the sketch recognition demo and it still doesn't seem to work: https://hf.space/gradioiframe/course-demos/draw2/+

Can you please check that these URLs are correct? Maybe the draw2 Space still needs to be migrated to course-demos?

Fixed the draw2 demo here (https://huggingface.co/spaces/course-demos/draw2)

@dawoodkhan82
dawoodkhan82 merged commit e22bcdc into main May 16, 2022
@dawoodkhan82
dawoodkhan82 deleted the dawood/course-demo-fixes branch May 16, 2022 14:34
GITbaburin pushed a commit to GITbaburin/course that referenced this pull request May 17, 2026
@dawoodkhan82
Merge pull request huggingface#178 from huggingface/dawood/course-dem…
742fd61 
…o-fixes

Fix links to new course demos + remove dark mode links + remove auth demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lewtun lewtun lewtun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dawoodkhan82 @HuggingFaceDocBuilderDev @lewtun