Skip to content

Chinese - Chapter 0,2finished #145

Merged
lewtun merged 19 commits into
huggingface:mainfrom
yaoqih:main
May 16, 2022
Merged

Chinese - Chapter 0,2finished #145
lewtun merged 19 commits into
huggingface:mainfrom
yaoqih:main

Conversation

@yaoqih

@yaoqih yaoqih commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

Hello, we have finished the translation of chapter zero and chapter two, please check. Among them, sections 1, 3, 5, and 7 of the chapter 2 were completed by @petrichor1122 , sections 2, 4, and 6 of the chapter 2 were completed by @zhlhyx , section 8 of the chapter 2 and chapter 0 were completed by me.

yaoqih and others added 10 commits April 12, 2022 00:53
 Add zh to the languages field in the build_documentation.yml and build_pr_documentation.yml files
Remove all these sections that haven't been translated yet
Remove Chapter 0 from the table of contents since it hasn't been translated yet
Fixed an error in the translation format of Chapter 1, Section 3
@yaoqih yaoqih closed this Apr 26, 2022
@lewtun

lewtun commented Apr 26, 2022

Copy link
Copy Markdown
Member

Hi @1375626371 did you accidentally close this PR? I'm happy to re-open and review it if you wish :) Just FYI that we now support zh-CN as the language code for the website, so I suggest renaming your folder as I did here: #119

@yaoqih

yaoqih commented Apr 27, 2022

Copy link
Copy Markdown
Contributor Author

Hi @1375626371 did you accidentally close this PR? I'm happy to re-open and review it if you wish :) Just FYI that we now support zh-CN as the language code for the website, so I suggest renaming your folder as I did here: #119

Okay, I understand. I will rename the folder in the next commit. The reason I closed this PR is that we found some errors during the code inspection. In order to ensure the quality, we have to re-check our translations. When the errors are corrected, we will re-open them again.

@lewtun

lewtun commented Apr 28, 2022

Copy link
Copy Markdown
Member

Okay, I understand. I will rename the folder in the next commit. The reason I closed this PR is that we found some errors during the code inspection. In order to ensure the quality, we have to re-check our translations. When the errors are corrected, we will re-open them again.

Sounds great! Looking forward to it 🤗

yaoqih added 2 commits May 3, 2022 13:21
·Fixed some formatting errors
·Moved Chapters 0 and 2 to Simplified Chinese
@yaoqih

yaoqih commented May 4, 2022

Copy link
Copy Markdown
Contributor Author

Okay, I understand. I will rename the folder in the next commit. The reason I closed this PR is that we found some errors during the code inspection. In order to ensure the quality, we have to re-check our translations. When the errors are corrected, we will re-open them again.

Sounds great! Looking forward to it 🤗

Hello, we have completed the inspection, please help us open this PR. Thank you!

@lewtun lewtun reopened this May 6, 2022
@lewtun

lewtun commented May 6, 2022

Copy link
Copy Markdown
Member

Thanks for iterating on this @1375626371 ! I think we just need to run make style to format the files and then this should be good for merging!

Comment thread chapters/zh-CN/chapter2/3.mdx Outdated
```

正如您之前看到的,我们可以用等效的AutoModel类替换Bert模型。从现在开始,我们将这样做,因为这会产生检查点不可知的代码;如果您的代码适用于一个检查点,那么它应该与另一个检查点无缝地工作。即使体系结构不同,这也适用,只要检查点是针对类似任务(例如,情绪分析任务)训练的。
{/if}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, we need a space here to build the docs. Can you please try this?

Suggested change
{/if}
{/if}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please wait a minute, we found this issue in the last merge, that's one reason we closed the PR provisionally , we've made some changes, and we'll upload our revised version later.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great!

yaoqih added 2 commits May 7, 2022 01:54
Formatting revisions and some translation corrections
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented May 6, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@yaoqih

yaoqih commented May 6, 2022

Copy link
Copy Markdown
Contributor Author

I run make style on local before commit. But it still fails the quality check, what should I do?

@lewtun

lewtun commented May 12, 2022

Copy link
Copy Markdown
Member

I run make style on local before commit. But it still fails the quality check, what should I do?

I fixed the formatting issues and pushed a fix :)

Since the CI passes, I think this is good to go! Thank you for the care and detail you've taken with this translation 🤗 !

@lewtun
lewtun merged commit aa8692c into huggingface:main May 16, 2022
lewtun added a commit that referenced this pull request May 16, 2022
@lewtun

lewtun commented May 16, 2022

Copy link
Copy Markdown
Member

I'm not sure why the French files were edited, so I'll revert this PR temporarily until I find a better solution

Edit: the changes are easy to resolve on the French side, so opting to retain this PR and fix on the French side of things.

PS. I think this was possibly caused by trying to merge the same branch (i.e. your main branch) that was used in a previous PR. You might want to create new branches with each PR to see if we can avoid these mysterious issues :)

GITbaburin pushed a commit to GITbaburin/course that referenced this pull request May 17, 2026
* Chinese - Chapter 1 finished

* Complete the translation of Chapters 0 and 2

* Fix style

Co-authored-by: Lewis Tunstall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants