Skip to content

[FA] First draft of CH2/P3#140

Merged
lewtun merged 20 commits into
huggingface:mainfrom
jowharshamshiri:review-ch3-p3
Apr 26, 2022
Merged

[FA] First draft of CH2/P3#140
lewtun merged 20 commits into
huggingface:mainfrom
jowharshamshiri:review-ch3-p3

Conversation

@jowharshamshiri

Copy link
Copy Markdown
Contributor

Translated CH2/P3
Additions to G.

@hamedonline please review. ❤️

Related to #50

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Apr 23, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@hamedonline

Copy link
Copy Markdown
Contributor

Translated CH2/P3 Additions to G.

@hamedonline please review. ❤️

Related to #50

Great work ❤️, thanks @jowharshamshiri aziz.
Will do my best tonight :)

Comment thread chapters/fa/chapter2/3.mdx Outdated
Comment thread chapters/fa/chapter2/3.mdx Outdated
Comment thread chapters/fa/chapter2/3.mdx Outdated
Comment thread chapters/fa/chapter2/3.mdx
Comment thread chapters/fa/chapter2/3.mdx Outdated
Comment thread chapters/fa/chapter2/3.mdx Outdated
Comment thread chapters/fa/chapter2/3.mdx Outdated
Comment thread chapters/fa/chapter2/3.mdx Outdated
Comment thread chapters/fa/chapter2/3.mdx Outdated

@hamedonline hamedonline left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job overall ❤️

Comment thread chapters/fa/chapter2/3.mdx Outdated
@jowharshamshiri

jowharshamshiri commented Apr 25, 2022

Copy link
Copy Markdown
Contributor Author

Fantastic job overall heart

@hamedonline jan, applied your notes please check. ❤️

@lewtun lewtun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @jowharshamshiri and @schoobani ❤️ ! Just ping me when you think this is ready to be merged - structurally it all looks good on my side 🚀

Comment thread chapters/fa/chapter2/3.mdx Outdated

@hamedonline hamedonline left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just apply the small fix for "می توانیم" dear @jowharshamshiri and after that we're good to go @lewtun ❤️

@jowharshamshiri

jowharshamshiri commented Apr 25, 2022

Copy link
Copy Markdown
Contributor Author

Please just apply the small fix for "می توانیم" dear @jowharshamshiri and after that we're good to go @lewtun heart

Thanks for the review @hamedonline jan and @lewtun please merge. ❤️

@jowharshamshiri

jowharshamshiri commented Apr 25, 2022

Copy link
Copy Markdown
Contributor Author

@letwun The checks seem to be failing... looking into it.

UPDATE: I think there was a change upstream in chapters/en/chapter1/4.mdx. Pulled and merged into the branch for this review. Checks pass now. ❤️

@lewtun
lewtun merged commit d19585c into huggingface:main Apr 26, 2022
@lewtun

lewtun commented Apr 26, 2022

Copy link
Copy Markdown
Member

Thank you very much for the contribution @jowharshamshiri and thank you @hamedonline for the review!

GITbaburin pushed a commit to GITbaburin/course that referenced this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants