[FA] Second draft of CH2/P1-2#139
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
|
@hamedonline jan can you please review this? @kambizG jan seems momentarily busy. This is the second draft of the pages you already reviewed, with a few changes for more natural language. It's been open for 19 days. |
Sure thing @jowharshamshiri jan, will keep you updated when done. |
Hi @jowharshamshiri and @hamedonline jan, sorry for such a long delay. I was too busy last few days. I'm back now and will be active as much as I can. |
hamedonline
left a comment
hamedonline
left a comment
There was a problem hiding this comment.
Great work @jowharshamshiri jan, I enjoyed countless great sentences during the review ❤️
Great review @hamedonline jan, thanks for the attention to detail. ❤️ |
|
I can live with that.
…On Fri, May 20, 2022 at 12:57 PM Hamed Homaei Rad ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In chapters/fa/chapter2/2.mdx
<#139 (comment)>:
> @@ -342,9 +342,9 @@ torch.Size([2, 2])
از آنجا که ما تنها دو جمله و دو دسته ممکن داشتیم، خروجی مدل ما شکل ۲ در ۲ دارد.
Within this text, batch is batch. That's specifically why we
transliterated. دسته is class in classify bc classify is دستهبندی; it's
only logical. We have the glossary, and our iron-clad adherence to it to
protect against ambiguities. We never use دسته to refer to a batch. And
when we repeatedly use دستهبندی the readers make the connection with دسته
Also using گروه for this very technical word violates our rule about being
consistent with technical equivalents.
What do you think?
Mostly agree with you @jowharshamshiri
<https://github.com/jowharshamshiri>, I'm not a fan of "گروه" term
either. My previous point on "دسته" still remains though and I've seen it
many times in Persian ML literature as an equivalent for "batch". Looks
like all the ways lead to preferring the use of "برچسب" for now in order to
prevent misinterpretation.
—
Reply to this email directly, view it on GitHub
<#139 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6KJRL7TLHDZ5JYPR3BL43VK5EHFANCNFSM5UDFA6YA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
hamedonline
left a comment
hamedonline
left a comment
There was a problem hiding this comment.
Thanks for the great work @jowharshamshiri jan, let's get the merge done ❤️
Thanks for the time you spent on this review, and @lewtun please kindly merge. 😍😍 |
lewtun
left a comment
lewtun
left a comment
There was a problem hiding this comment.
Thank you both for this epic PR and review 🔥 !
Retroactive update of CH2/P1-2 per glossary updates.
Second draft of CH2/P1-2 for more natural language.
Added "Head" to the G.
Added lines to TRANSLATING for important pages in the style guide.
@kambizG please review. ❤️
Related to #50