[FA] First draft of Chapter4/Page1#134
Conversation
|
@hamedonline supercool and thanks for the diacritics fix in _toctree.yml. I think you forgot to include the glossary file, please push that too. |
I thought of a separate push for that in which we could discuss about some other suggestions & tweaks I had in mind. Do you agree? |
Ok, never mind. I'll commit along and we'll have additional discussions on that file 😃. |
We need a second draft PR on this page, I think you missed a couple of small spots but don't want to drag this review too long. By making small commits on each review point and checking them together we can avoid this. As for the glossary, please include your changes in this PR. I can fetch the changes to my fork so that I can retroactively apply them to my pages in my next PR. I am also available if you want to discuss these changes and anything else you have in mind. If you need other collaborators we can mention them here and ask for their opinion. This ensures everybody always has the latest glossary when working(T/point5). With frequent fetching they can clearly see what changed and apply the changes, which minimizes the editing required and shortens the review process. |
@jowharshamshiri I'm super-ok to continue resolving them here, please open open up review remarks on missed spots. |
jowharshamshiri
left a comment
There was a problem hiding this comment.
Thanks so much for this. I'd love to hear your choice for "attention mechanism" I need that in my page.
|
Sorry, an accidental close. |
@jowharshamshiri Here are the nominees I can think of (I did some googling too):
The first one though seems to be more common in the literature. |
|
If you are ok with it, I like the first one too. |
|
@jowharshamshiri I have couple of more suggestions for glossary terms, perhaps not necessary for this PR; we can talk about them later on issue page.
|
All are cool with me. |
Related to #50
Reviews are welcome @jowharshamshiri @schoobani