Skip to content

[FA] First draft of Chapter4/Page1#134

Merged
lewtun merged 15 commits into
huggingface:mainfrom
hamedonline:main
Apr 22, 2022
Merged

[FA] First draft of Chapter4/Page1#134
lewtun merged 15 commits into
huggingface:mainfrom
hamedonline:main

Conversation

@hamedonline

Copy link
Copy Markdown
Contributor
  • added chapter4/page1
  • updated _toctree.yml to include added page

Related to #50

Reviews are welcome @jowharshamshiri @schoobani

@jowharshamshiri jowharshamshiri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! ❤️
Please include updates to the glossary page.

Comment thread chapters/fa/chapter4/1.mdx Outdated
Comment thread chapters/fa/chapter4/1.mdx Outdated
Comment thread chapters/fa/chapter4/1.mdx Outdated
Comment thread chapters/fa/chapter4/1.mdx Outdated
Comment thread chapters/fa/chapter4/1.mdx Outdated
Comment thread chapters/fa/chapter4/1.mdx Outdated
Comment thread chapters/fa/chapter4/1.mdx Outdated
Comment thread chapters/fa/chapter4/1.mdx Outdated
Comment thread chapters/fa/chapter4/1.mdx Outdated
Comment thread chapters/fa/_toctree.yml Outdated
@jowharshamshiri

Copy link
Copy Markdown
Contributor

@hamedonline supercool and thanks for the diacritics fix in _toctree.yml. I think you forgot to include the glossary file, please push that too.

@hamedonline

Copy link
Copy Markdown
Contributor Author

@hamedonline supercool and thanks for the diacritics fix in _toctree.yml. I think you forgot to include the glossary file, please push that too.

I thought of a separate push for that in which we could discuss about some other suggestions & tweaks I had in mind. Do you agree?

@hamedonline

Copy link
Copy Markdown
Contributor Author

@hamedonline supercool and thanks for the diacritics fix in _toctree.yml. I think you forgot to include the glossary file, please push that too.

I thought of a separate push for that in which we could discuss about some other suggestions & tweaks I had in mind. Do you agree?

Ok, never mind. I'll commit along and we'll have additional discussions on that file 😃.

@jowharshamshiri

Copy link
Copy Markdown
Contributor

@hamedonline supercool and thanks for the diacritics fix in _toctree.yml. I think you forgot to include the glossary file, please push that too.

I thought of a separate push for that in which we could discuss about some other suggestions & tweaks I had in mind. Do you agree?

We need a second draft PR on this page, I think you missed a couple of small spots but don't want to drag this review too long. By making small commits on each review point and checking them together we can avoid this.

As for the glossary, please include your changes in this PR. I can fetch the changes to my fork so that I can retroactively apply them to my pages in my next PR. I am also available if you want to discuss these changes and anything else you have in mind. If you need other collaborators we can mention them here and ask for their opinion. This ensures everybody always has the latest glossary when working(T/point5). With frequent fetching they can clearly see what changed and apply the changes, which minimizes the editing required and shortens the review process.

@hamedonline

Copy link
Copy Markdown
Contributor Author

We need a second draft PR on this page, I think you missed a couple of small spots but don't want to drag this review too long. By making small commits on each review point and checking them together we can avoid this.

@jowharshamshiri I'm super-ok to continue resolving them here, please open open up review remarks on missed spots.

@jowharshamshiri jowharshamshiri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this. I'd love to hear your choice for "attention mechanism" I need that in my page.

Comment thread chapters/fa/glossary/1.mdx Outdated
Comment thread chapters/fa/glossary/1.mdx Outdated
Comment thread chapters/fa/glossary/1.mdx Outdated
Comment thread chapters/fa/chapter4/1.mdx Outdated
@hamedonline

hamedonline commented Apr 22, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, an accidental close.

@hamedonline hamedonline reopened this Apr 22, 2022
@hamedonline

Copy link
Copy Markdown
Contributor Author

Thanks so much for this. I'd love to hear your choice for "attention mechanism" I need that in my page.

@jowharshamshiri Here are the nominees I can think of (I did some googling too):

  • مکانیزم توجه
  • سازوکار توجه
  • مکانیزم ژرف‌نگری

The first one though seems to be more common in the literature.

@jowharshamshiri

Copy link
Copy Markdown
Contributor

If you are ok with it, I like the first one too.

Comment thread chapters/fa/glossary/1.mdx
Comment thread chapters/fa/glossary/1.mdx Outdated
@hamedonline

Copy link
Copy Markdown
Contributor Author

@jowharshamshiri I have couple of more suggestions for glossary terms, perhaps not necessary for this PR; we can talk about them later on issue page.

  • Subword -> زیرکلمه
  • Index, as in an array or list -> اندیس
  • Tokenized -> توکِن‌شده

@jowharshamshiri

Copy link
Copy Markdown
Contributor

@jowharshamshiri I have couple of more suggestions for glossary terms, perhaps not necessary for this PR; we can talk about them later on issue page.

  • Subword -> زیرکلمه

  • Index, as in an array or list -> اندیس

  • Tokenized -> توکِن‌شده

All are cool with me.

@lewtun

lewtun commented Apr 22, 2022

Copy link
<