Skip to content

Chinese - Chapter 1 finished#113

Merged
lewtun merged 8 commits into
huggingface:mainfrom
yaoqih:main
Apr 13, 2022
Merged

Chinese - Chapter 1 finished#113
lewtun merged 8 commits into
huggingface:mainfrom
yaoqih:main

Conversation

@yaoqih

@yaoqih yaoqih commented Apr 11, 2022

Copy link
Copy Markdown
Contributor

Translation to Chinese: chapter 1 finished
@petrichor1122 and @zhlhyx completed their respective sections and we made the submission together.

@lewtun lewtun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all for translating a whole chapter 🤯 ! This looks great and the only thing we need to do is tweak the table of contents

To test we can build the docs in the CI, could you please add zh to the languages field in the build_documentation.yml and build_pr_documentation.yml files? In other words, something like this:

 languages: ar bn en es fa fr he ko pt ru th tr zh

Comment thread chapters/zh/_toctree.yml Outdated
title: 章末小测验
quiz: 1

- title: 2. Using 🤗 Transformers

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove all these sections that haven't been translated yet

Comment thread chapters/zh/_toctree.yml Outdated
@@ -0,0 +1,173 @@
- title: 0. 准备

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove Chapter 0 from the table of contents since it hasn't been translated yet

yaoqih added 3 commits April 12, 2022 21:13
 Add zh to the languages field in the build_documentation.yml and build_pr_documentation.yml files
Remove all these sections that haven't been translated yet
Remove Chapter 0 from the table of contents since it hasn't been translated yet
@yaoqih

yaoqih commented Apr 12, 2022

Copy link
Copy Markdown
Contributor Author

We made the required changes. @lewtun

@lewtun lewtun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the final tweaks! This looks great and I'll merge when the CI passes 😍

@lewtun

lewtun commented Apr 12, 2022

Copy link
Copy Markdown
Member

Ah it seems we have some issues with the code formatting. Could you please run:

python -m pip install -r requirements.txt

followed by

make style

yaoqih added 2 commits April 13, 2022 01:15
Fixed an error in the translation format of Chapter 1, Section 3
@yaoqih

yaoqih commented Apr 12, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, we have some formatting errors, which we have checked and fixed.

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Apr 13, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lewtun

lewtun commented Apr 13, 2022

Copy link
Copy Markdown
Member

Nice, the content renders great!

Screen Shot 2022-04-13 at 11 15 29

@@ -0,0 +1,31 @@
# Bias and limitations

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While looking at the rendered output I noticed this is still in English. Would it make sense to translate it too?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, there are some omissions because we are involved in translation for the first time, we will check the first chapter when the second chapter is translated, and these corrections will be fixed together when the second chapter is uploaded.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! I'll merge this now :)

@lewtun

lewtun commented Apr 13, 2022

Copy link
Copy Markdown
Member

We passed the code inspection locally, but did not pass the code quality inspection of github

Don't worry - I fixed it on my side :)

@lewtun
lewtun merged commit e812f74 into huggingface:main Apr 13, 2022
lewtun pushed a commit that referenced this pull request Apr 13, 2022
* Chinese - Chapter 1 finished

* Add zh to the languages field

Co-authored-by: petrichor1122 <[email protected]>
Co-authored-by: zhlhyx <[email protected]>
lewtun added a commit that referenced this pull request Apr 14, 2022
* ko-chapter1/1

* ko _toctree.yml created

* Fix the issue #80

* Single expression changed

* ko/chapter1 finished

* ko/chapter0 finished

* ko/chapter0 finished

* reviewed by @bzantium ko/chapter0

* reviewed by @bzantium chapter0 & fixed typo

* reviewed by @rainmaker712

* maximize Korean expressions

* [Chapter 1] bangla traslation initial commit

* Update 1.mdx

update and fix formating

* Fix formating and typos

* translate _toctree.yml 0-1 chapter

* Add Korean to CI

* [tr] Translated chapter1/2.mdx

* remove translation from sec titles not yet translated

* Add authors [th ru]

* [FIX] _toctree.yml

* Update chapters/bn/chapter0/1.mdx

[FIX] syntax formatting

Co-authored-by: lewtun <[email protected]>

* tag typos & indentation & unnatural expressions

* modified toctree.yml for chapter1/2

* modified toctree.yml for chapter1/2 & fix typo

* French Translation - Chapter 5

* Add Bengali to CI

* Update author list

* Adding translations for 2/4 and 2/5 🚀 (#74)

* Adding translations for 2/4 and 2/5 🚀

* Remove English content

Co-authored-by: lewtun <[email protected]>

* Translation to Russian (#97)

* translation of chapter 2/section 1

* add section 1 / chapter 2 to _toctree.yml

* Translation of Chapter0 to Hindi (#86)

* Hindi?Chapter0-Part_1

* Hindi/Chapter0-Part_2

* Chapter 0 Persian Translation First Draft (#95)

* merged branch0 into main. no toctree yet.

* updated toctree.

* Updated the glossary with terms from chapter0.

* Second draft in collab w/ @schoobani. Added empty chapter1 for preview.

* Glossary typo fix.

* Translation of Chapter0 (setup) to Arabic (#104)

* Add AR translation for `introduction`

* Fix alignment & format

* Add Arabic to CI build

* Russian - Chapter 1 finished (#98)

* 01/4 start

* 1/4 finished

* 1/5 finished

* 1/5 update toc

* 1/6 finished

* 1/7 finished

* 1/8 finished

* 1/9 finished

* 1/4 fix

* toc update

* Chinese - Chapter 1 finished (#113)

* Chinese - Chapter 1 finished

* Add zh to the languages field

Co-authored-by: petrichor1122 <[email protected]>
Co-authored-by: zhlhyx <[email protected]>

* [PT] Translation of chapter 2 (#107)

* add PT translate to 2.1

* add PT translate to 2.2

* add portuguese translation to 2.3

* WIP portuguese translation to 2.4

* add portuguese translation to 2.4

* add portuguese translation to 2.5

* add portuguese translation to 2.6

* add _toctree infos

Co-authored-by: lewtun <[email protected]>

* [FR] Translation of chapter 2 & event + Review of chapters 0 & 5 (#106)

* Update _toctree.yml

Add chapter 2 
+ little fix of chapter 5

* Update 1.mdx

Review of chapter 0

* Create 1.mdx

* Create 2.mdx

* Create 3.mdx

* Create 4.mdx

* Create 5.mdx

* Create 6.mdx

* Create 7.mdx

* Create 8.mdx

* Update 8.mdx

Since AutoNLP has recently been renamed to AutoTrain, let me make the correction on the English file

* Update 1.mdx

Review of chapter 5/1

* Update 2.mdx

Review of chapter 5/2

* Update 3.mdx

Review of chapter 5/3

* Update 4.mdx

Review of chapter 5/4

* Update 5.mdx

Review of chapter 5/5

* Update 6.mdx

Review of chapter 5/6

* Update 7.mdx

Review of chapter 5/7

* Update 8.mdx

Review of chapter 5/8

* Create 1.mdx

event's translation

* Update _toctree.yml

add event to the tree

* Update _toctree.yml

deletion of the files that pose a problem to pass the checks, will be resubmitted in another PR

* Delete 1.mdx

deletion of the files that pose a problem to pass the checks, will be resubmitted in another PR

* make style correction

* Update _toctree.yml

the -

* Fix spacing

Co-authored-by: Lewis Tunstall <[email protected]>

* [th] Translated Chapter2/1 (#83)

* Finish chapter2/1

* Update _toctree.yml

* ko-chapter1/1

* ko _toctree.yml created

* Fix the issue #80

* Single expression changed

* ko/chapter1 finished

* ko/chapter0 finished

* ko/chapter0 finished

* reviewed by @bzantium ko/chapter0

* reviewed by @bzantium chapter0 & fixed typo

* reviewed by @rainmaker712

* maximize Korean expressions

* [Chapter 1] bangla traslation initial commit

* Update 1.mdx

update and fix formating

* Fix formating and typos

* translate _toctree.yml 0-1 chapter

* Add Korean to CI

* remove translation from sec titles not yet translated

* Add authors [th ru]

* [FIX] _toctree.yml

* Update chapters/bn/chapter0/1.mdx

[FIX] syntax formatting

Co-authored-by: lewtun <[email protected]>

* tag typos & indentation & unnatural expressions

* modified toctree.yml for chapter1/2

* modified toctree.yml for chapter1/2 & fix typo

* Add Bengali to CI

* Update author list

* Adding translations for 2/4 and 2/5 🚀 (#74)

* Adding translations for 2/4 and 2/5 🚀

* Remove English content

Co-authored-by: lewtun <[email protected]>

* Translation to Russian (#97)

* translation of chapter 2/section 1

* add section 1 / chapter 2 to _toctree.yml

* Translation of Chapter0 to Hindi (#86)

* Hindi?Chapter0-Part_1

* Hindi/Chapter0-Part_2

* Chapter 0 Persian Translation First Draft (#95)

* merged branch0 into main. no toctree yet.

* updated toctree.

* Updated the glossary with terms from chapter0.

* Second draft in collab w/ @schoobani. Added empty chapter1 for preview.

* Glossary typo fix.

* Translation of Chapter0 (setup) to Arabic (#104)

* Add AR translation for `introduction`

* Fix alignment & format

* Add Arabic to CI build

* Russian - Chapter 1 finished (#98)

* 01/4 start

* 1/4 finished

* 1/5 finished

* 1/5 update toc

* 1/6 finished

* 1/7 finished

* 1/8 finished

* 1/9 finished

* 1/4 fix

* toc update

* Chinese - Chapter 1 finished (#113)

* Chinese - Chapter 1 finished

* Add zh to the languages field

Co-authored-by: petrichor1122 <[email protected]>
Co-authored-by: zhlhyx <[email protected]>

* [PT] Translation of chapter 2 (#107)

* add PT translate to 2.1

* add PT translate to 2.2

* add portuguese translation to 2.3

* WIP portuguese translation to 2.4

* add portuguese translation to 2.4

* add portuguese translation to 2.5

* add portuguese translation to 2.6

* add _toctree infos

Co-authored-by: lewtun <[email protected]>

* [FR] Translation of chapter 2 & event + Review of chapters 0 & 5 (#106)

* Update _toctree.yml

Add chapter 2 
+ little fix of chapter 5

* Update 1.mdx

Review of chapter 0

* Create 1.mdx

* Create 2.mdx

* Create 3.mdx

* Create 4.mdx

* Create 5.mdx

* Create 6.mdx

* Create 7.mdx

* Create 8.mdx

* Update 8.mdx

Since AutoNLP has recently been renamed to AutoTrain, let me make the correction on the English file

* Update 1.mdx

Review of chapter 5/1

* Update 2.mdx

Review of chapter 5/2

* Update 3.mdx

Review of chapter 5/3

* Update 4.mdx

Review of chapter 5/4

* Update 5.mdx

Review of chapter 5/5

* Update 6.mdx

Review of chapter 5/6

* Update 7.mdx

Review of chapter 5/7

* Update 8.mdx

Review of chapter 5/8

* Create 1.mdx

event's translation

* Update _toctree.yml

add event to the tree

* Update _toctree.yml

deletion of the files that pose a problem to pass the checks, will be resubmitted in another PR

* Delete 1.mdx

deletion of the files that pose a problem to pass the checks, will be resubmitted in another PR

* make style correction

* Update _toctree.yml

the -

* Fix spacing

Co-authored-by: Lewis Tunstall <[email protected]>

* [th] Translated Chapter2/1 (#83)

* Finish chapter2/1

* Update _toctree.yml

* Add Hindi to CI (#116)

Co-authored-by: DOOHAE JUNG <[email protected]>
Co-authored-by: m_khandaker <[email protected]>
Co-authored-by: Md. Al-Amin Khandaker <[email protected]>
Co-authored-by: ftarlaci <[email protected]>
Co-authored-by: Doohae Jung <[email protected]>
Co-authored-by: melaniedrevet <[email protected]>
Co-authored-by: Jose M Munoz <[email protected]>
Co-authored-by: svv73 <[email protected]>
Co-authored-by: Vedant Pandya <[email protected]>
Co-authored-by: Bahram Shamshiri <[email protected]>
Co-authored-by: Giyaseddin Bayrak <[email protected]>
Co-authored-by: Pavel <[email protected]>
Co-authored-by: 1375626371 <[email protected]>
Co-authored-by: petrichor1122 <[email protected]>
Co-authored-by: zhlhyx <[email protected]>
Co-authored-by: João Gustavo A. Amorim <[email protected]>
Co-authored-by: lbourdois <[email protected]>
Co-authored-by: Cherdsak Kingkan <[email protected]>
lewtun added a commit that referenced this pull request Apr 25, 2022
* ko-chapter1/1

* ko _toctree.yml created

* Fix the issue #80

* Single expression changed

* ko/chapter1 finished

* ko/chapter0 finished

* ko/chapter0 finished

* reviewed by @bzantium ko/chapter0

* reviewed by @bzantium chapter0 & fixed typo

* reviewed by @rainmaker712

* maximize Korean expressions

* [Chapter 1] bangla traslation initial commit

* Update 1.mdx

update and fix formating

* Fix formating and typos

* translate _toctree.yml 0-1 chapter

* Add Korean to CI

* [tr] Translated chapter1/2.mdx

* remove translation from sec titles not yet translated

* Add authors [th ru]

* [FIX] _toctree.yml

* Update chapters/bn/chapter0/1.mdx

[FIX] syntax formatting

Co-authored-by: lewtun <[email protected]>

* tag typos & indentation & unnatural expressions

* modified toctree.yml for chapter1/2

* modified toctree.yml for chapter1/2 & fix typo

* French Translation - Chapter 5

* Add Bengali to CI

* Update author list

* Adding translations for 2/4 and 2/5 🚀 (#74)

* Adding translations for 2/4 and 2/5 🚀

* Remove English content

Co-authored-by: lewtun <[email protected]>

* Translation to Russian (#97)

* translation of chapter 2/section 1

* add section 1 / chapter 2 to _toctree.yml

* Translation of Chapter0 to Hindi (#86)

* Hindi?Chapter0-Part_1

* Hindi/Chapter0-Part_2

* Chapter 0 Persian Translation First Draft (#95)

* merged branch0 into main. no toctree yet.

* updated toctree.

* Updated the glossary with terms from chapter0.

* Second draft in collab w/ @schoobani. Added empty chapter1 for preview.

* Glossary typo fix.

* Translation of Chapter0 (setup) to Arabic (#104)

* Add AR translation for `introduction`

* Fix alignment & format

* Add Arabic to CI build

* Russian - Chapter 1 finished (#98)

* 01/4 start

* 1/4 finished

* 1/5 finished

* 1/5 update toc

* 1/6 finished

* 1/7 finished

* 1/8 finished

* 1/9 finished

* 1/4 fix

* toc update

* Chinese - Chapter 1 finished (#113)

* Chinese - Chapter 1 finished

* Add zh to the languages field

Co-authored-by: petrichor1122 <[email protected]>
Co-authored-by: zhlhyx <[email protected]>

* [PT] Translation of chapter 2 (#107)

* add PT translate to 2.1

* add PT translate to 2.2

* add portuguese translation to 2.3

* WIP portuguese translation to 2.4

* add portuguese translation to 2.4

* add portuguese translation to 2.5

* add portuguese translation to 2.6

* add _toctree infos

Co-authored-by: lewtun <[email protected]>

* [FR] Translation of chapter 2 & event + Review of chapters 0 & 5 (#106)

* Update _toctree.yml

Add chapter 2 
+ little fix of chapter 5

* Update 1.mdx

Review of chapter 0

* Create 1.mdx

* Create 2.mdx

* Create 3.mdx

* Create 4.mdx

* Create 5.mdx

* Create 6.mdx

* Create 7.mdx

* Create 8.mdx

* Update 8.mdx

Since AutoNLP has recently been renamed to AutoTrain, let me make the correction on the English file

* Update 1.mdx

Review of chapter 5/1

* Update 2.mdx

Review of chapter 5/2

* Update 3.mdx

Review of chapter 5/3

* Update 4.mdx

Review of chapter 5/4

* Update 5.mdx

Review of chapter 5/5

* Update 6.mdx

Review of chapter 5/6

* Update 7.mdx

Review of chapter 5/7

* Update 8.mdx

Review of chapter 5/8

* Create 1.mdx

event's translation

* Update _toctree.yml

add event to the tree

* Update _toctree.yml

deletion of the files that pose a problem to pass the checks, will be resubmitted in another PR

* Delete 1.mdx

deletion of the files that pose a problem to pass the checks, will be resubmitted in another PR

* make style correction

* Update _toctree.yml

the -

* Fix spacing

Co-authored-by: Lewis Tunstall <[email protected]>

* [th] Translated Chapter2/1 (#83)

* Finish chapter2/1

* Update _toctree.yml

* Add Hindi to CI (#116)

* Update README.md (#87)

* Update authors on README (#120)

* Update authors

* French translation `Chapter1` full (#56)


* traduction 1st part of chapter1

* fix typo

* fix job titles and encoder-decoder translation

* add part 2 for 1st chapter

* fix some typo part2

* fix Transformer -> Transformers

* add part 3 not totally ended

* end of part3 of chapter1

* part9 chapter 1

* add part7 chapter 1

* add part5 chapter 1

* part 6 chapter 1

* add part8 chapter 1

* end quizz of chapter

* add last part of chapter 1

Co-authored-by: ChainYo <[email protected]>

* Translate to Japanese Chapter0 (#123)

* start working

* translate chapter0/1.mdx

* [FA] First draft of Chapter2/Page2 (#129)

* merged branch0 into main. no toctree yet.

* updated toctree.

* Updated the glossary with terms from chapter0.

* Second draft in collab w/ @schoobani. Added empty chapter1 for preview.

* Glossary typo fix.

* Added missing backticks.

* Removed a couple of bad indefinite articles I forgot.

* First draft of ch2/p2. Adds to glossary. Trans. guidelines moved out.

* Fixed missing diacritics, fixed the py/tf switch placing. Other fixes.

* Changed the equivalent for prediction per