Italian translation of 1.mdx#103
Conversation
lewtun
left a comment
lewtun
left a comment
There was a problem hiding this comment.
Hi @CaterinaBi thank you for this great contribution and congrats on your first PR to the Hugging Face ecosystem 🔥 !
As @sharkovsky mentioned, we should only include the files that have been translated, so all the original English ones can be deleted. Please let us know if you need some help with Git and we'll be happy to provide it 🤗
| sections: | ||
| - local: chapter1/1 | ||
| title: Introduzione | ||
| - local: chapter1/2 |
There was a problem hiding this comment.
Thanks for translating the whole ToC, but we only need to include the sections for which there are MDX files in Italian. In your case, we have chapter0/1.mdx and chapter1/1.mdx translated, so the _toctree.yml file should just include:
- title: 0. Installazione
sections:
- local: chapter0/1
title: Introduzione
- title: 1. Modelli Transformer
sections:
- local: chapter1/1
title: Introduzione
|
Hi @CaterinaBi , how are things going? Let me know if i can help in any way! |
Hi @sharkovsky , I'm so sorry I ghosted you, I had all sorts of weird things happening to me: I first found myself without any network on the Italian Dolomites for 10 days (thankfully I had planned to take time off from work, so I didn't have any planned meetings!), then I came back to England and realised I forgot my sim card in my mother's phone when she brought me her Italian sim to see whether I'd be able to get some work done using that as a hotspot (that network was terrible too, by the way). So I was locked out of all websites and applications that required a double identification. I should have had GitHub security coded but couldn't find them anywhere... A modern nightmare! Anyway, I'll be trying to get things right tonight and come back to you if I see I can't update the pull request alone. Because of all that happened I'm also so late with the translations, I feel super guilty! |
|
Welcome back @CaterinaBi 🤗 ! Please let us know if you need any help :) |
Hello @lewtun! Sorry I disappeared, I feel so bad about this! I've tried to update the pull request, will you please let me know if I've done all correctly this time? Just to double check: how do you want me to proceed? Do I open a pull request each time I'm done translating a file (and updating the ToC)? |
lewtun
left a comment
lewtun
left a comment
There was a problem hiding this comment.
Thanks for the fixes @CaterinaBi - this is looking great! There's just a small fix needed for the ToC and could you please add the it language code to the languages field of the build_documentation.yml and build_pr_documentation.yml files? You want to add something like:
languages: ar bn de en es fa fr gj he hi it ja ko pt ru th tr zh-CN
| - title: 0. Installazione | ||
| sections: | ||
| - local: chapter0/1 | ||
| title: Introduzione |
There was a problem hiding this comment.
I think we lost the piece for chapter1/1 😬 . Could you add the following below this line:
- title: 1. Modelli Transformer
sections:
- local: chapter1/1
title: IntroduzioneThere was a problem hiding this comment.
thank you very much for your help, @lewtun! All should be done correctly now (or at least I hope so).
I'm very grateful for your help, I'm learning so much!
There was a problem hiding this comment.
Thanks for this! It seems that we just have some merge conflicts to resolve on the build_pr_documentation.yml and build_documentation.yml files - would you be happy to fix that?
There was a problem hiding this comment.
Ok so I've just resolved my first conflicts ever. Hopefully I didn't make a mess!
Yes, this would be great! From other translations, I think it's a bit faster if you group a few sections together in a single PR, but of course we'll happily accept single sections 🤗 |
lewtun
left a comment
lewtun
left a comment
There was a problem hiding this comment.
Thanks for the final fix! I'm now running the CI to check if the docs build and we should soon see the first part of the course in Italian 🇮🇹 !
Great! Thank you very much @lewtun, I owe you a couple of drinks! |
|
The documentation is not available anymore as the PR was closed or merged. |
|
Woohoo it worked 🥳 ! Merging this now :)
|
|
Yay! Thanks again! |
4 participants
No description provided.