Remove unsafe constructs #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It isn't obvious that creating a Vec<u8> with uninitialised content is safe: https://www.ralfj.de/blog/2019/07/14/uninit.html#what-can-you-do-with-uninitialized-memory
This achieves the same optimisation as prior to 06958a9, but without using `unsafe`. Moreover, this avoids nested zip()s and iter_mut(), so it might be faster.
Contributor
Author
|
@hucsmn This should now be mergeable. |
hucsmn
reviewed
Nov 25, 2019
Owner
There was a problem hiding this comment.
Thanks for your commits! Uninitialized vector may lead to UB if elements were readed before initialization. This is a premature optimization indeed, I would like to add some benchmarks later. For now, safe code is better.
Following codes could be simplified:
This is more concise and faster.
Again, faster and more concise.
Contributor
Author
|
Done, thanks for the feedback <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qbsdiffusesunsafecode in various places to build uninitialisedVec<u8>s with a given size.Unfortunately, this probably is undefined behaviour, so it should be removed.
bsdiffunsaferemoved;bspatch:Context::{buf,dlt}caches are now managed safely.unsafecode is now forbidden within the crate.