Fix #readpartial not respecting max length argument

janko · tarcieri · commit 800c58157445 · 2018-02-11T17:01:10.000-08:00
diff --git a/lib/http/connection.rb b/lib/http/connection.rb
@@ -86,9 +86,11 @@ def send_request(req)
     def readpartial(size = BUFFER_SIZE)
       return unless @pending_response
 
+      chunk = @parser.get_chunk(size)
+      return chunk if chunk
+
       finished = (read_more(size) == :eof) || @parser.finished?
       chunk    = @parser.chunk
-
       finish_response if finished
 
       chunk.to_s
diff --git a/lib/http/response/parser.rb b/lib/http/response/parser.rb
@@ -3,7 +3,7 @@
 module HTTP
   class Response
     class Parser
-      attr_reader :headers
+      attr_reader :headers, :chunk
 
       def initialize
         @parser = HTTP::Parser.new(self)
@@ -43,9 +43,17 @@ def on_body(chunk)
         end
       end
 
-      def chunk
-        chunk  = @chunk
-        @chunk = nil
+      def get_chunk(size)
+        return if @chunk.nil?
+
+        if @chunk.bytesize <= size
+          chunk  = @chunk
+          @chunk = nil
+        else
+          chunk = @chunk.byteslice(0, size)
+          @chunk[0, size] = ""
+        end
+
         chunk
       end
 
