feat: add Error::from_display & from_debug #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
approved these changes
Mar 23, 2021
Member
yoshuawuyts
left a comment
yoshuawuyts
left a comment
There was a problem hiding this comment.
I wonder if from_error_lossy might a more descriptive naming, since "lossy" is only ever used as a suffix in the stdlib. But if that might be too confusing, it's fine as-is too.
Fishrock123
force-pushed
the
Error-from_lossy
branch
from
e7ba958 to
52b55d1
Compare
Member
Author
|
@yoshuawuyts Is this more in line with what you'd hope for? Or is this straying to far from |
yoshuawuyts
approved these changes
Apr 5, 2021
Fishrock123
changed the title
Fishrock123
force-pushed
the
Error-from_lossy
branch
from
52b55d1 to
d224da4
Compare
This is handy for errors (or other structs) which are not `Send + Sync + 'static`.
Fishrock123
force-pushed
the
Error-from_lossy
branch
from
d224da4 to
196244f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is handy for errors which are not
Send + Sync + 'static.