stabilize upgrade in response #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
reviewed
Nov 30, 2020
jbr
requested changes
Nov 30, 2020
Member
jbr
left a comment
jbr
left a comment
There was a problem hiding this comment.
looks like cfg_unstable needs to be removed from src/utils/mod.rs for ci to pass, and we should check if we're actually using the unstable feature anywhere. if not, we should remove the feature
jbr
approved these changes
Nov 30, 2020
Member
|
refs: #291 |
Fishrock123
approved these changes
Dec 1, 2020
Member
Fishrock123
left a comment
Fishrock123
left a comment
There was a problem hiding this comment.
#291 should come first but if we are stabilizing that then this goes hand-in-hand.
Member
Member
|
Oh, guess i had it backwards then 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yoshuawuyts / @jbr, I start working in an example using websocket based on littoral and I found that some changes are needed in this branch
stabilize-upgradeto supportws.I tested ok in my example but let me know if something is wrong, thanks for the awesome job!!! 🙌