make it so upgrade connections can be built from the outside #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
reviewed
Nov 25, 2020
| /// An upgraded HTTP connection. | ||
| #[derive(Debug, Clone)] | ||
| pub struct RawConnection<Inner> { | ||
| inner: Inner, |
Member
There was a problem hiding this comment.
If Connection is RawConnection<Box<dyn T>> anyways, why isn't inner just directly Box<dyn T>?
Member
There was a problem hiding this comment.
Good question; not sure. I think we should pick that up when stabilizing the upgradesubmodule.
Member
Author
|
This (the creation of a Connection) will only ever be used in one place probably, so it's not worth adding an Into. I think this code probably could be simplified, but that's not what this PR is about |
Fishrock123
approved these changes
Nov 26, 2020
yoshuawuyts
approved these changes
Nov 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.