Implement ToHeaderValues for more string types
#279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
approved these changes
Nov 9, 2020
jbr
reviewed
Nov 9, 2020
Member
There was a problem hiding this comment.
Could these be defined in terms of the ToHeaderValues for &'a str impl to reduce duplicated code? Similarly, the String one probably could also be defined as
impl ToHeaderValues for String {
type Iter = option::IntoIter<HeaderValue>;
fn to_header_values(&self) -> crate::Result<Self::Iter> {
self.as_str().to_header_values()
}
}That way if changes were needed to the &str impl, it wouldn't have to be repeated in four places
delete-merged-branch
bot
deleted the
to-header-values-for-more-string-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
ToHeaderValuesfor more string types. Noticed that passing&format!("{}", "value")as the header value didn't work, butformat!("{}", "value").as_str()does. This fixes that. Thanks!