Skip to content

Conversation

@jbr
Copy link
Member

@jbr jbr commented Oct 15, 2020

Related to http-rs/surf#86

Copy link
Member

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

Self::new(StatusCode::InternalServerError, error)
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems accidental

@faulesocke
Copy link

The only thing required for interop with anyhow and similar crates is an implementation of std::error::Error. No dependency on anyhow or anything else is required.

@jbr
Copy link
Member Author

jbr commented Nov 20, 2020

@faulesocke please PR that

@Fishrock123
Copy link
Member

@jbr Any reason you haven't merged this?

@jbr
Copy link
Member Author

jbr commented Nov 21, 2020

Nope just keep forgetting to remove the newline you pointed out when I'm at a keyboard. Meeting as-is

@jbr jbr merged commit add09b9 into http-rs:main Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants