headers: etag: reject invalid characters #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I see that the clippy fix is also submitted via #234 . |
Member
|
@ririsoft I have merged the clippy fixes. |
rfc7232 specifies a valid set of ASCII characters that etag headers should match.
ririsoft
force-pushed
the
etag-fix-valid-chars
branch
from
007e8eb to
0f26be1
Compare
Fishrock123
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rfc7232 specifies a valid set of ASCII characters that etag headers should match.
This PR is adding the missing character validation.
Some similar implementation can be found in Go for instance.