Skip to content

Conversation

@yoshuawuyts
Copy link
Member

Implements the Vary header. Ref #99. Depends on #220, #224. This is actually the final conditional header, heh.

Vary takes a HeaderName as an input, so made it so it can take both header names and string literals for convenience. I think this should work reasonably well. Thanks!

@goto-bus-stop goto-bus-stop changed the base branch from master to main August 9, 2020 12:58
@yoshuawuyts yoshuawuyts changed the title Vary Add conditional::Vary Aug 20, 2020
@ririsoft ririsoft mentioned this pull request Aug 24, 2020
@yoshuawuyts yoshuawuyts marked this pull request as ready for review September 19, 2020 22:14
@yoshuawuyts
Copy link
Member Author

The VaryDirective struct isn't needed; but that matches the rest of the directives and we can fix that in a follow-up PR.

@yoshuawuyts yoshuawuyts merged commit 4817f9e into main Sep 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the vary branch September 19, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants