add support for multiline data messages #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `data` passed to `Sender::send()` is prepended with `data:` and written as-is. If the data string contains newlines, that causes any data beyond the newline(s) to end up on a line that does not begin with `data:`, which the spec dictates should be ignored. This change splits the message on newlines and writes each line with its own `data:` prefix.
yoshuawuyts
approved these changes
Sep 6, 2021
Member
yoshuawuyts
left a comment
yoshuawuyts
left a comment
There was a problem hiding this comment.
This looks great, thanks so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
datapassed toSender::send()is prepended withdata:and written as-is. If the data string contains newlines, that causes any data beyond the newline(s) to end up on a line that does not begin withdata:, which the spec dictates should be ignored (or, worse, if the message itself contains a field name, likeevent:orid:, after a newline, it could register on the client side as a separate event). This change splits the message on newlines and writes each line with its owndata:prefix.The decoder code seems to handle this case correctly already.