Skip to content

Fix Encoder AsyncRead, implement AsyncBufRead #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yoshuawuyts merged 2 commits into from
Oct 26, 2020
Merged

Fix Encoder AsyncRead, implement AsyncBufRead #13

yoshuawuyts merged 2 commits into from
Oct 26, 2020

Conversation

@akhilles
Copy link
Contributor

@akhilles akhilles commented Oct 10, 2020

Fixes #12.

I noticed the AsyncBufRead implementation for Encoder was commented out. Was this intentional? If so, I can remove those changes.

@NathanFlurry
Copy link

NathanFlurry commented Oct 25, 2020

Ran in to the same issue with `Encoder::poll_read. This PR correctly patches it on my end.

yoshuawuyts
yoshuawuyts approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps!

@yoshuawuyts yoshuawuyts merged commit 79ef595 into http-rs:main Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Encoder can possibly send duplicate bytes

3 participants

@akhilles @NathanFlurry @yoshuawuyts