Skip to content

Take &str data argument in send() #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goto-bus-stop merged 3 commits into from
Apr 23, 2020
Merged

Take &str data argument in send() #1

goto-bus-stop merged 3 commits into from
Apr 23, 2020

Conversation

@goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Apr 23, 2020 •
edited
Loading

EventSource streams are required to be utf-8, and we can encode that requirement in the type system by using &str for the data argument :)

@goto-bus-stop goto-bus-stop reopened this Apr 23, 2020
@goto-bus-stop goto-bus-stop merged commit 14500db into master Apr 23, 2020
@goto-bus-stop goto-bus-stop deleted the send-str branch April 23, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goto-bus-stop @yoshuawuyts