Fix websocket socket close before response#1552
Open
FinnStutzenstein wants to merge 1 commit intohttp-party:masterfrom
FinnStutzenstein:fix-websocket-upgrade-closed-socket
Open
Fix websocket socket close before response#1552FinnStutzenstein wants to merge 1 commit intohttp-party:masterfrom FinnStutzenstein:fix-websocket-upgrade-closed-socket
FinnStutzenstein wants to merge 1 commit intohttp-party:masterfrom
FinnStutzenstein:fix-websocket-upgrade-closed-socket
Conversation
There are situations where the socket can already be closed. Writing to it will result in a "This socket has been ended by the other party" error which results in the node service to terminate (cannot be catched by a try-catch block).
roderik
added a commit
to settlemint-archive/node-http-proxy
that referenced
this pull request
Nov 25, 2021
BerndSchrooten
added a commit
to datacamp-engineering/node-http-proxy
that referenced
this pull request
Jun 8, 2022
likev
added a commit
to likev/node-http-proxy
that referenced
this pull request
Feb 23, 2023
ravin00
approved these changes
Oct 27, 2024
58 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
Check socket.writable before writing the HTTP response when the upstream does not upgrade the connection. Prevents uncatchable "socket has been ended" errors when the client disconnects before the response arrives. Upstream: http-party/node-http-proxy#1552
3 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
Check socket.writable before writing the HTTP response when the upstream does not upgrade the connection. Prevents uncatchable "socket has been ended" errors when the client disconnects before the response arrives. Upstream: http-party/node-http-proxy#1552
|
This issue has been fixed in unjs/httpxy#114. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are situations where the socket can already be closed. Writing to
it will result in a "This socket has been ended by the other party"
error which results in the node service to terminate (cannot be catched
by a try-catch block).