header could be empty string#1551
Open
damiandragowski wants to merge 1 commit intohttp-party:masterfrom
Open
Conversation
changing condition, do setHeader only when header is not
null
undefined
NaN
empty string ("")
0
false
58 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
…P_TOKEN add explicit guard for empty/whitespace-only header keys in writeHeaders (upstream http-party/node-http-proxy#1551)
2 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
add explicit guard for empty/whitespace-only header keys in writeHeaders (upstream http-party/node-http-proxy#1551)
|
This issue has been fixed in unjs/httpxy#121. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changing condition, do setHeader only when header is not
null
undefined
NaN
empty string ("")
0
false
It preserve from exception:
[HPM] GET /events?uuids=18cd56cb-45cb-43e6-a397-c4531cc57866 -> http://localhost:8099
_http_outgoing.js:545
throw new ERR_INVALID_HTTP_TOKEN('Header name', name);
^
TypeError [ERR_INVALID_HTTP_TOKEN]: Header name must be a valid HTTP token [""]
at ServerResponse.setHeader (_http_outgoing.js:563:3)