Fix handling of client disconnect so that econnreset event is emitted instead of error#1542
Open
gsf4726 wants to merge 1 commit intohttp-party:masterfrom
Open
Fix handling of client disconnect so that econnreset event is emitted instead of error#1542gsf4726 wants to merge 1 commit intohttp-party:masterfrom
gsf4726 wants to merge 1 commit intohttp-party:masterfrom
Conversation
… instead of error
|
Thank you so much for this fix; this issue has been the bane of my life for weeks and your solution totally fixes it. Would love to see this merged ASAP so I don't have to keep on modifying my local http-proxy files. |
|
Fix works great. I have been using it on my project. Would be awesome to see this merged in! Please.... :) |
edspencer
pushed a commit
to oplabs/node-http-proxy
that referenced
this pull request
Nov 19, 2021
|
Looks like this project is dead, so in order to use this fix we just forked the project and made the 1 line change in this PR. It seems to work for us. Took about 30 mins, but better than manually editing that file in node_modules 🤦 |
roderik
added a commit
to settlemint-archive/node-http-proxy
that referenced
this pull request
Nov 25, 2021
ReyRod
approved these changes
Dec 7, 2021
|
As this project is dead, we had to apply this change with https://www.npmjs.com/package/patch-package, thanks for the solution @gsf4726 |
BerndSchrooten
added a commit
to datacamp-engineering/node-http-proxy
that referenced
this pull request
Jun 8, 2022
|
Monkey patching function for who don't want to use the patch-package. function monkeyPatchHttpProxyLibrary() {
// https://github.com/http-party/node-http-proxy/pull/1542
const filePath = path.join(
__dirname,
'../node_modules/http-proxy/lib/http-proxy/passes/web-incoming.js',
);
const fileContent = fs.readFileSync(filePath, 'utf-8');
const patchedFileContent = fileContent.replace(
`if (req.socket.destroyed && err.code === 'ECONNRESET') {`,
`if (req.aborted && err.code === 'ECONNRESET') {`,
);
fs.writeFileSync(filePath, patchedFileContent, 'utf-8');
} |
58 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
Check `!req.socket?.writable` instead of `req.socket.destroyed` in the proxy error handler. The socket `writable` flag is set to false earlier than `destroyed` during client disconnection, avoiding a race condition where ECONNRESET errors were incorrectly routed to the `error` event. Ref: http-party/node-http-proxy#1542
3 tasks
|
This issue has been fixed in unjs/httpxy#115. |
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
Check `!req.socket?.writable` instead of `req.socket.destroyed` in the proxy error handler. The socket `writable` flag is set to false earlier than `destroyed` during client disconnection, avoiding a race condition where ECONNRESET errors were incorrectly routed to the `error` event. Ref: http-party/node-http-proxy#1542
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
Check `!req.socket?.writable` instead of `req.socket.destroyed` in the proxy error handler. The socket `writable` flag is set to false earlier than `destroyed` during client disconnection, avoiding a race condition where ECONNRESET errors were incorrectly routed to the `error` event. Ref: http-party/node-http-proxy#1542
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1455