fix(outgoing-opts): preference for values in ssl#1504
Open
stanleynguyen wants to merge 1 commit intohttp-party:masterfrom
Open
fix(outgoing-opts): preference for values in ssl#1504stanleynguyen wants to merge 1 commit intohttp-party:masterfrom
stanleynguyen wants to merge 1 commit intohttp-party:masterfrom
Conversation
Preventing overwriting of undefined first-layer key from the main options
58 tasks
Denoder
added a commit
to refactorjs/http-proxy
that referenced
this pull request
Dec 19, 2023
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
When `setupOutgoing` copies properties like `cert`, `key`, `ca` from the target object, undefined values would overwrite existing ssl options passed via `options.ssl`. Skip assignment when the target value is undefined. Upstream: http-party/node-http-proxy#1504
2 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
#118) When `setupOutgoing` copies properties like `cert`, `key`, `ca` from the target object, undefined values would overwrite existing ssl options passed via `options.ssl`. Skip assignment when the target value is undefined. Upstream: http-party/node-http-proxy#1504
|
This issue has been fixed in unjs/httpxy#118. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preventing overwriting by undefined first-layer key from the main options
Resolves #1503