do not pipe req into proxyReq until socket is connected#1495
Open
pepmartinez wants to merge 1 commit intohttp-party:masterfrom
Open
do not pipe req into proxyReq until socket is connected#1495pepmartinez wants to merge 1 commit intohttp-party:masterfrom
pepmartinez wants to merge 1 commit intohttp-party:masterfrom
Conversation
(allows retry of proxy.web() on connection refused, for example
|
Don't you need to emit the proxyReq event before the pipe call? If the pipe sends the first chunk then the headers will be sent with it and won't be mutable when the proxyReq event is generated. |
Author
|
Well, all I did is to defer the pipe() until there's a socket. There were no emit() before, to start with |
58 tasks
Denoder
added a commit
to refactorjs/http-proxy
that referenced
this pull request
Dec 19, 2023
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
Avoid piping request body into proxyReq before the underlying socket is connected. Piping eagerly can consume the request stream, causing body data loss when retrying the same request to an alternate target. Ref: http-party/node-http-proxy#1495
2 tasks
|
This issue has been fixed in unjs/httpxy#111. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While building a reverse proxy with ha-lb capabilities I found out that proxy.web() does not play totally well with retries if a request body is present: it turns out the original req is piped into the proxyReq immediately, even before the socket at proxyReq tries to connect; such piping would read some (or even all) of the original req's body even if the socket does not connect; those body bytes would be lost if we choose to proxy.web() the same request onto an alternative target
The patch delays the piping until proxyReq's socket is present, and it's either connected (that is, reused from an agent) or suceeds to connect