Skip to content

replace all http:/ with http:// bug fix#1487

Closed
imagekitio wants to merge 1 commit intohttp-party:masterfrom
imagekitio:fix/replace-http-global
Closed

replace all http:/ with http:// bug fix#1487
imagekitio wants to merge 1 commit intohttp-party:masterfrom
imagekitio:fix/replace-http-global

Conversation

@imagekitio
Copy link
Copy Markdown

Test case added to help understand the issue

it('should replace multiple http:/ with http://', function () {
      var outgoing = {};
      common.setupOutgoing(outgoing, {
        target: { path: '/' },
      }, { url: '/xyz/http://foobar.com/http://foobar.com/https://foobar.com' });

      expect(outgoing.path).to.eql('/xyz/http://foobar.com/http://foobar.com/https://foobar.com');
    })

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants