Fix socket read error when websocket upgrade failed#1439
Open
houfeng0923 wants to merge 1 commit intohttp-party:masterfrom
Open
Fix socket read error when websocket upgrade failed#1439houfeng0923 wants to merge 1 commit intohttp-party:masterfrom
houfeng0923 wants to merge 1 commit intohttp-party:masterfrom
Conversation
Author
|
BTW, it only happen in ssl mode |
2 tasks
58 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
When a WebSocket upgrade request hits a target that responds with a
non-upgrade HTTP response (e.g., 502) and the upstream connection resets
mid-body, the `res` stream emits an unhandled error that crashes the
process. Add `res.on("error", onOutgoingError)` before piping, and guard
against writing to already-destroyed sockets.
Ref: http-party/node-http-proxy#1439
4 tasks
|
This issue has been fixed in unjs/httpxy#116. |
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
When a WebSocket upgrade request hits a target that responds with a
non-upgrade HTTP response (e.g., 502) and the upstream connection resets
mid-body, the `res` stream emits an unhandled error that crashes the
process. Add `res.on("error", onOutgoingError)` before piping, and guard
against writing to already-destroyed sockets.
Ref: http-party/node-http-proxy#1439
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
When a WebSocket upgrade request hits a target that responds with a
non-upgrade HTTP response (e.g., 502) and the upstream connection resets
mid-body, the `res` stream emits an unhandled error that crashes the
process. Add `res.on("error", onOutgoingError)` before piping, and guard
against writing to already-destroyed sockets.
Ref: http-party/node-http-proxy#1439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebSocket proxy will throw below exception when target server not ready(target nginx return default http 502 response at current time).
BTW, If cause by websocket, i think the reason for this is the same as the issue #1017 。