fix: check if socket is destroyed before writing to it#1433
Open
flotwig wants to merge 1 commit intohttp-party:masterfrom
Open
fix: check if socket is destroyed before writing to it#1433flotwig wants to merge 1 commit intohttp-party:masterfrom
flotwig wants to merge 1 commit intohttp-party:masterfrom
Conversation
|
Bump |
58 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
…onse guard against writing to an already-destroyed client socket when the upstream responds with a plain HTTP response instead of a WebSocket upgrade. applies to both ProxyServer.ws() and proxyUpgrade() paths. ref: http-party/node-http-proxy#1433
3 tasks
|
This issue has been fixed in unjs/httpxy#113. |
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
…onse guard against writing to an already-destroyed client socket when the upstream responds with a plain HTTP response instead of a WebSocket upgrade. applies to both ProxyServer.ws() and proxyUpgrade() paths. ref: http-party/node-http-proxy#1433
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1432
net_socket.destroyedappears to exist as of at least Node 6.0.0 👍