adjust web-icoming handling of https protocol checks#1419
Open
alsoscotland wants to merge 1 commit intohttp-party:masterfrom
Open
adjust web-icoming handling of https protocol checks#1419alsoscotland wants to merge 1 commit intohttp-party:masterfrom
alsoscotland wants to merge 1 commit intohttp-party:masterfrom
Conversation
- inconsistency between regex check and === 'https:' resulted in
mismatch of secure port and protocol in common.setupOutgoing
58 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
…l checks Upstream: http-party/node-http-proxy#1419 The forward, target, and redirect code paths used `=== "https:"` which missed `wss:` and other SSL protocol variants. The rest of the codebase already uses the shared `isSSL` regex — align these three call sites.
2 tasks
|
This issue has been fixed in unjs/httpxy#123. |
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
…l checks (#123) * fix(web-incoming): use `isSSL` regex for consistent https/wss protocol checks Upstream: http-party/node-http-proxy#1419 The forward, target, and redirect code paths used `=== "https:"` which missed `wss:` and other SSL protocol variants. The rest of the codebase already uses the shared `isSSL` regex — align these three call sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mismatch of secure port and protocol in common.setupOutgoing
#1418