Feature: Add 'mergeCookies' options#1375
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1375 +/- ##
==========================================
+ Coverage 92.35% 92.61% +0.25%
==========================================
Files 6 6
Lines 314 325 +11
==========================================
+ Hits 290 301 +11
Misses 24 24
Continue to review full report at Codecov.
|
RidgeA
force-pushed
the
feature/add_merge_cookie_options
branch
from
1fc1ef4 to
5fa7a1c
Compare
RidgeA
force-pushed
the
feature/add_merge_cookie_options
branch
from
5fa7a1c to
11480ab
Compare
jsmylnycky
left a comment
jsmylnycky
left a comment
There was a problem hiding this comment.
Besides the couple spots to clean up the quotations, looks good to me. Go ahead and fix those up, and I'll put a note to review this PR for one of the next couple releases.
Thanks 😄
| header = common.rewriteCookieProperty(header, rewriteCookiePathConfig, 'path'); | ||
| } | ||
| if (mergeCookiesConfig && key.toLowerCase() === 'set-cookie') { | ||
| header = common.mergeSetCookie(res.getHeader("set-cookie"), header) |
There was a problem hiding this comment.
Nitpick: Replace the " with '
|
|
||
| this.proxyRes.headers = Object.assign({}, this.proxyRes.headers, {'set-cookie': 'hello1; domain=my.domain; path=/'}); | ||
|
|
||
| this.res.setHeader("set-cookie", 'hello; domain=my.domain; path=/'); |
There was a problem hiding this comment.
Nitpick: Replace the " with '
jsmylnycky
added
the
Will merge
jsmylnycky
changed the title
|
Hello, Any updates for this feature merge? Thanks |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1375 +/- ##
==========================================
+ Coverage 92.35% 92.61% +0.25%
==========================================
Files 6 6
Lines 314 325 +11
==========================================
+ Hits 290 301 +11
Misses 24 24 ☔ View full report in Codecov by Sentry. |
5 participants
Replace of #1318