Fix option.target can't contains question mark#1334
Open
lf541512 wants to merge 1 commit intohttp-party:masterfrom
Open
Fix option.target can't contains question mark#1334lf541512 wants to merge 1 commit intohttp-party:masterfrom
lf541512 wants to merge 1 commit intohttp-party:masterfrom
Conversation
58 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
When the proxy target URL contains a query string (e.g., `http://example.com/api?key=val`), it was silently dropped because `setupOutgoing` only read `.pathname` from the target URL. Now the target's `.search` is extracted and properly merged with any request query string, using `&` as separator when both are present. Upstream: http-party/node-http-proxy#1334
4 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
When the proxy target URL contains a query string (e.g., `http://example.com/api?key=val`), it was silently dropped because `setupOutgoing` only read `.pathname` from the target URL. Now the target's `.search` is extracted and properly merged with any request query string, using `&` as separator when both are present. Upstream: http-party/node-http-proxy#1334
|
This issue has been fixed in unjs/httpxy#117. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix case target:
http://www.example.com?project=.example&path=,and incoming requrest with query _t=123456