Adds support for protocol relative URLs in location header#1298
Open
bruderstein wants to merge 1 commit intohttp-party:masterfrom
Open
Adds support for protocol relative URLs in location header#1298bruderstein wants to merge 1 commit intohttp-party:masterfrom
bruderstein wants to merge 1 commit intohttp-party:masterfrom
Conversation
tjenkinson
reviewed
Oct 11, 2018
| // remove it so we retain the protocol relative | ||
| // of the response URL | ||
| if (protocolPrefix) { | ||
| u.protocol = ''; |
There was a problem hiding this comment.
Maybe it should not be cleared if the 'protocolRewrite' option is used?
`url.parse` doesn't parse protocol relative URLs, but they are valid in location headers according to RFC7231 (https://tools.ietf.org/html/rfc7231#section-7.1.2, and specified in RFC3986 https://tools.ietf.org/html/rfc3986#section-4.2) This commit fixes that by temporarily adding an `http:` to a URL that begins with `//` before parsing and removing the protocol before formatting.
|
Are there any updates? |
Closed
7 tasks
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
url.parsedoesn't parse protocol relative URLs, but they are validin location headers according to RFC7231
(https://tools.ietf.org/html/rfc7231#section-7.1.2, and specified in
RFC3986 https://tools.ietf.org/html/rfc3986#section-4.2)
This commit fixes that by temporarily adding an
http:to a URL thatbegins with
//before parsing and removing the protocol beforeformatting.