Disable the 2 minutes default incoming timeout by default, matches proxyTimeout defaut behavior#1273
Open
Johny101 wants to merge 1 commit intohttp-party:masterfrom
Open
Disable the 2 minutes default incoming timeout by default, matches proxyTimeout defaut behavior#1273Johny101 wants to merge 1 commit intohttp-party:masterfrom
Johny101 wants to merge 1 commit intohttp-party:masterfrom
Conversation
DESCRIPTION: If the incoming timeout option is not set or if set to 0, it will be disabled. It will now have the same default behavior than the incoming proxyTimeout option. This replace the default node.js 2 minutes timeout and now support disabling it. TEST: In a Windows and Arm-Linux environment, set option.timeout to 0, to 5 minutes and remove option. Run a 8 minutes long request. Confirm expected behavior for all cases.
Codecov Report
@@ Coverage Diff @@
## master #1273 +/- ##
=========================================
Coverage ? 92.35%
=========================================
Files ? 6
Lines ? 314
Branches ? 0
=========================================
Hits ? 290
Misses ? 24
Partials ? 0
Continue to review full report at Codecov.
|
|
@indexzero Is anything preventing this PR from being merged. The issue it fix bites quite often and there seem not to have easy workarounds? |
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
This modification will save head hakes to those playing with long HTTP request.
Thanks!
Johny
DESCRIPTION:
Now, if the incoming timeout option is not set or if set to 0, it will be disabled by setting the req.socket timeout to 0.
This replace the default node.js 2 minutes timeout and now support disabling it.
It will have the same default behavior than the incoming proxyTimeout option.
TEST:
In a Windows and Arm-Linux environment, set option.timeout to 0, to 5 minutes and no timeout option.
Run a 8 minutes long request. Confirm expected behavior for all cases.