Conversation
hraban
left a comment
hraban
left a comment
There was a problem hiding this comment.
Hi,
Thanks for your contribution. I think it could be worth merging.
I like the last commit, but the first two introduce a lot of unnecessary noise. Could you remove those and rebase?
And if you could, please add a little comment to the README explaining the new syntax?
Thanks again.
tomono.sh
Outdated
| fi | ||
|
|
||
| if [[ -z "$folder" ]]; then | ||
| folder=$name |
There was a problem hiding this comment.
to be safe, I'd prefer to always quote any variable in bash. folder="$name"
|
Hi there, I've reverted the whitespace commits. I imagine you can squash the PR to remove all the extra commits... I've made the README change and Thanks. |
|
Thanks. I've rebased your patches to avoid thrashing the history and paralysing git blame, but otherwise no changes. To maintainers: Please don't merge this PR!Merge #25 instead. |
|
@hraban - quick git question: would squashing the merge commit avoid thrashing the history and paralysing git blame? |
|
Yes, that's what I did in #25. Squash all commits except the readme, and move the last commit above the readme to squash it in, as well. Assuming you're on branch feature/folder-name and your master is in line with ours; use |
|
Oh - I mean just use github to do it for you? e.g.
|
|
Ahh, gotcha. Yes, but I don’t have any write permissions on this repo :) I can only create prs, myself (left the company a few years back). The actual maintainers, God bless, come in once every few months and seem to merge everything without perhaps paying too much attention, so that could go wrong. :)
Gotta play the hand you’re dealt. In the end, the result is the same, though, no?
… On 10 Apr 2018, at 01:11, Douglas Reith ***@***.***> wrote:
Oh - I mean just use github to do it for you? e.g.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
lol, ok @hraban :) |
3 participants
Hi there,
This PR is just to show you what I did. I don't expect it to be merged. I can submit another if you think some of it is worthwhile.
Basically I wanted to optionally pass a folder name with some depth, e.g.
echo '/home/user/repo.git library-package lib/packages/library-package' | tomono.sh
So in the monorepo you'll find ./lib/packages/library-package/*
I think I received an
lserror at some point but otherwise it seems to work.Thanks for the script.