Support 2-Decimal Formatting & customizable decimal separator by DarkSmile92 · Pull Request #192 · hql287/Manta

DarkSmile92 · 2018-01-25T12:53:32Z

Shows 2 fractions on decimals and makes the decimal separator region aware.

Close #190, Closes #173

request-info · 2018-01-25T12:53:33Z

The maintainers of this repository would appreciate it if you could provide more information.

hql287 · 2018-01-25T14:30:48Z

@DarkSmile92: This is not finished yet, right?

DarkSmile92 · 2018-01-25T17:25:00Z

@hql287 No I am adding the two settings right now and implement the display of currency sign before / after the amount. Will commit to PR and let you know once I'm done.
the latest tomorrow, have a lot of meetings today, sorry :(

hql287 · 2018-01-25T22:54:13Z

@DarkSmile92 No pressure, Robin. I just added a [WIP] tag to the title, feel free to remove it once you're done with the PR. Thanks!

DarkSmile92 · 2018-01-29T09:50:54Z

Thanks @hql287 !
If you have time, please review the current changes. I think I got all relevant places but maybe I missed some places.

hql287 · 2018-01-29T16:55:42Z

@DarkSmile92 Will do. Thanks!

hql287 · 2018-01-31T09:41:10Z

@DarkSmile92 Robin, I just tested out your PR and this is pretty cool. Everything seems to be working as expected. I really like the currency sign placement setting. Nice touch! 👍

There're still some issues though:

Did you forget about Customizable decimal separator #190? I don't see the setting to choose between comma (,) and dot (.) as the decimal separator
If the price is 499.50 and the fraction is 2, it will print 499 which is incorrect.
If the decimal fraction is negative (eg -2), it will return an error. I know this is silly but it would be nice to show a dialogue rather than letting the app crash.
The tests are broken

DarkSmile92 · 2018-01-31T09:51:26Z

@hql287 Hung you are right, I totally forgot #190 sorry 😟
I will check the other points and edit the tests (which I also forgot to customize).
I'll commit tonight

hql287 · 2018-01-31T09:54:56Z

@DarkSmile92 Thanks, bro! 👍

DarkSmile92 · 2018-02-01T11:12:32Z

@hql287

Customizable decimal separator #190 Settings for decimal separator
Checked with price of 499.50. Shows correct fractions when using 499.50.
Catched exception when fraction setting is <0 (with message for user)
I customized the settings components to have a state "canSave". This can be used for further validations on the settings later.
It throws a warning notification and does not let the user save if decimalFractions is < 0
Tests customized

hql287 · 2018-02-01T12:28:39Z

 );
+
+// Notify user about invalid decimal fractions
+export const notifyInvalidDecimalFractions = createAction(


Please use dialog for validation message. I would like to user to acknowledge this before moving on.

hql287 · 2018-02-01T12:36:36Z

@DarkSmile92 Robin, can you allow me to push to your PR?

DarkSmile92 · 2018-02-01T13:41:19Z

@hql287 Already checked, you should be able to push to my PR Hung 👍

It’s too big at the moment

hql287 · 2018-02-02T12:48:15Z

@DarkSmile92 I just added some new definitions to facilitate the changes in this PR. Can you do the translation for those term on Crowdin (I would like to add German support with this PR)?

Thanks!

DarkSmile92 · 2018-02-02T12:56:52Z

@hql287 Sure, translation on Crowdin done :)

Currency settings now hold these 4 settings as default: - Currency (code) - Separator (thousand & decimal) - Sign placement - Decimal fraction Refactored FormReducer, Invoice & Currency component (in Settings page) with these changes

+ All operations related to constructing a new invoice has been moved to form helper. This makes sencse since most of them are already here and testing will be easier, too.

Also changed name to formatNumber

+ Invoices Container: + Invoice (Invoices Page) : display currency correctly + Settings Reducer: removed unnecessary selectors

hql287 · 2018-02-05T17:30:53Z

Almost done.

Validation rule (and tests) for currency in Form/Setting
Test for formatNumber helper
Mmigration scheme for exsiting invoices

@DarkSmile92: If you can review the changes, that would be great! 👍

+ Validate negative fraction, tax amount and item quantity + Added test cases

DarkSmile92 · 2018-02-07T21:38:00Z

@hql287 sorry for not responding, something came up at work that needed my full attention. I reviewed the changes. I really like that you made currency an object with decimal and placement properties. This makes it extensible. All changes look good to me to I agree. Can't approve them via git review so take this as review succeeded and approved:)

hql287 · 2018-02-09T07:32:03Z

@DarkSmile92 Thanks, bro 👍

Closes hql287#190, Closes hql287#173

dd3d16e

DarkSmile92 mentioned this pull request Jan 25, 2018

Translation of settings page #191

Closed

hql287 changed the title ~~Closes hql287/Manta#190, Closes hql287/Manta#173~~ Support 2-Decimal Formatting Jan 25, 2018

hql287 changed the title ~~Support 2-Decimal Formatting~~ Support 2-Decimal Formatting & customizable decimal separator Jan 25, 2018

hql287 changed the title ~~Support 2-Decimal Formatting & customizable decimal separator~~ [WIP] Support 2-Decimal Formatting & customizable decimal separator Jan 25, 2018

DarkSmile92 and others added 2 commits January 29, 2018 10:17

Merge branch 'dev' into dev

7e77648

Preview and Invoices list

1b8fd42

hql287 and others added 3 commits February 1, 2018 13:24

Merge branch 'dev' into dev

812f2ae

hql287#190 tests and other points

733ca44

Merge branch 'dev' of https://github.com/DarkSmile92/Manta into dev

e0df73c

Removed console logs and eslint errors

a7e196b

hql287 reviewed Feb 1, 2018

View reviewed changes

hql287 assigned DarkSmile92 Feb 1, 2018

hql287 added the feature-request label Feb 1, 2018

Use dialog instead of notification

4473f69

hql287 added 3 commits February 2, 2018 15:05

Refactored Invoice setting component

3916e2f

It’s too big at the moment

Merge branch 'dev' into dev

4c157b0

Added new definitions

9bc2ede

Refactored Invoice settings tab

7b8c458

hql287 added 13 commits February 2, 2018 23:40

Merge branch 'dev' into dev

ac85c09

Merge branch 'dev' into dev

8167821

Merge branch 'dev' into dev

b70229d

Reimplemented currency settings

0325b95

Currency settings now hold these 4 settings as default: - Currency (code) - Separator (thousand & decimal) - Sign placement - Decimal fraction Refactored FormReducer, Invoice & Currency component (in Settings page) with these changes

Refactored InvoiceMW & Form helper

ff5d8e8

+ All operations related to constructing a new invoice has been moved to form helper. This makes sencse since most of them are already here and testing will be easier, too.

Moved numer helper to application helpers folder

d7aeefe

Also changed name to formatNumber

Updated Currency component in Form

21db7a0

Refactored Tax & Recipient Form with the shared Part component

015f2fa

Refactored components

a510844

+ Invoices Container: + Invoice (Invoices Page) : display currency correctly + Settings Reducer: removed unnecessary selectors

Make sure numbers are displayed correctly in templates

5b25aab

Send notification when saveAsDefault successfully

171d18d

Updated translation

637b8d0

Fixed tests

17d8343

hql287 added 3 commits February 6, 2018 00:39

Updated translation

91284b0

Clear the form if the invoice is being editted

c8b851c

Refactored validation rules, tests & added translation

cfe6e41

+ Validate negative fraction, tax amount and item quantity + Added test cases

hql287 changed the title ~~[WIP] Support 2-Decimal Formatting & customizable decimal separator~~ Support 2-Decimal Formatting & customizable decimal separator Feb 10, 2018

hql287 added 2 commits February 11, 2018 10:24

Updated migration for invoices

a2de896

Refactored formatNumber helper and added tests

ae3a05d

hql287 merged commit e64f2dd into hql287:dev Feb 11, 2018

Uh oh!

Conversation

DarkSmile92 commented Jan 25, 2018 • edited by hql287 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

request-info bot commented Jan 25, 2018

Uh oh!

hql287 commented Jan 25, 2018

Uh oh!

DarkSmile92 commented Jan 25, 2018

Uh oh!

hql287 commented Jan 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DarkSmile92 commented Jan 29, 2018

Uh oh!

hql287 commented Jan 29, 2018

Uh oh!

hql287 commented Jan 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DarkSmile92 commented Jan 31, 2018

Uh oh!

hql287 commented Jan 31, 2018

Uh oh!

DarkSmile92 commented Feb 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hql287 Feb 1, 2018

Choose a reason for hiding this comment

Uh oh!

DarkSmile92 Feb 1, 2018

Choose a reason for hiding this comment

Uh oh!

hql287 commented Feb 1, 2018

Uh oh!

DarkSmile92 commented Feb 1, 2018

Uh oh!

hql287 commented Feb 2, 2018

Uh oh!

DarkSmile92 commented Feb 2, 2018

Uh oh!

hql287 commented Feb 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DarkSmile92 commented Feb 7, 2018

Uh oh!

hql287 commented Feb 9, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DarkSmile92 commented Jan 25, 2018 •

edited by hql287

Loading

hql287 commented Jan 25, 2018 •

edited

Loading

hql287 commented Jan 31, 2018 •

edited

Loading

DarkSmile92 commented Feb 1, 2018 •

edited

Loading

hql287 commented Feb 5, 2018 •

edited

Loading