In order for the PyPy GC to recognize HPyFields, the call to HPyField_Store and HPyField_Load must be also given the HPyObject holding the relevant storage struct. But in this code the HPyField is in the dt_slots struct held by PyArray_DTypeMeta *new_dtype_data and not on new_dtype_data itself. This is the HPyField that later causes HPyField_Load to fail.

numpy-hpy/numpy/core/src/multiarray/dtypemeta.c

Lines 750 to 757 in 23f4a18

    
           PyArray_DTypeMeta *new_dtype_data = PyArray_DTypeMeta_AsStruct(ctx, h_new_dtype_type); 
        
           new_dtype_data->dt_slots = dt_slots; 
        
           HPy h_castingimpls = HPyDict_New(ctx); 
        
           if (HPy_IsNull(h_castingimpls)) { 
        
               goto cleanup; 
        
           } 
        
           HPyField_Store(ctx, h_new_dtype_type, &dt_slots->castingimpls, h_castingimpls);

I found this by adding debug code inside HPyField_Store that checks that the storage pointer is reasonably "close" to the HPyField value (after discussion with @antocuni).

I do not see a way that PyPy can chase down the HPyField hidden in the void *slots struct. I think that for the HPy port we must embed the struct inside the PyArray_DTypeMeta.

numpy-hpy/numpy/core/include/numpy/experimental_dtype_api.h

Lines 161 to 171 in 23f4a18

    
           typedef struct { 
        
               PyHeapTypeObject super; 
        
               HPyField singleton; 
        
               int type_num; 
        
               HPyField scalar_type; 
        
               npy_uint64 flags; 
        
               void *dt_slots; 
        
               void *reserved[3]; 
        
           } PyArray_DTypeMeta; 
        
           HPyType_LEGACY_HELPERS(PyArray_DTypeMeta)

	PyArray_DTypeMeta *new_dtype_data = PyArray_DTypeMeta_AsStruct(ctx, h_new_dtype_type);
	new_dtype_data->dt_slots = dt_slots;

	HPy h_castingimpls = HPyDict_New(ctx);
	if (HPy_IsNull(h_castingimpls)) {
	goto cleanup;
	}
	HPyField_Store(ctx, h_new_dtype_type, &dt_slots->castingimpls, h_castingimpls);

	typedef struct {
	PyHeapTypeObject super;
	HPyField singleton;
	int type_num;
	HPyField scalar_type;
	npy_uint64 flags;
	void *dt_slots;
	void *reserved[3];
	} PyArray_DTypeMeta;

	HPyType_LEGACY_HELPERS(PyArray_DTypeMeta)

Building with PyPy #15

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions