Merged
Conversation
| sha-1 = "0.8.0" | ||
| slab = "0.4" | ||
| url = "1.7.0" | ||
| url = "2.0.0" |
There was a problem hiding this comment.
What about allowing the 1.7 version as well?
Something like
Suggested change
| url = "2.0.0" | |
| url = ">=1.7, <3.0.0" |
Contributor
Author
Contributor
There was a problem hiding this comment.
It's a bad idea, it makes it look like end users can continue to use 1.7, but cargo will happily bring url 2 in their project anyway and then you have "expected Url, got Url" type errors.
Collaborator
There was a problem hiding this comment.
Yeah, I'm against ranges too
There was a problem hiding this comment.
It's a bad idea, it makes it look like end users can continue to use 1.7, but cargo will happily bring url 2 in their project anyway and then you have "expected
Url, gotUrl" type errors.
I did not know that.
This was referenced Jul 23, 2019
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Aug 16, 2019
Update the url crate to 2.0 Blocked on: * [x] housleyjk/ws-rs#283 + undoing corresponding `[patch.crates-io]` entry Soft-blocked on: (we could add to the crate duplication allow-list instead) * [x] ~rust-windowing/winit#1066 - [x] rust-windowing/winit#1076 * [x] servo/media#288 * [ ] servo/webrender#3720 * [x] gobwas/influent.rs#22 * [ ] https://bugzilla.mozilla.org/show_bug.cgi?id=1568540 - [x] seanmonstar/warp#260 - [ ] abonander/multipart#121 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23838) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Aug 16, 2019
Update the url crate to 2.0 Blocked on: * [x] housleyjk/ws-rs#283 + undoing corresponding `[patch.crates-io]` entry Soft-blocked on: (we could add to the crate duplication allow-list instead) * [x] ~rust-windowing/winit#1066 - [x] rust-windowing/winit#1076 * [x] servo/media#288 * [ ] servo/webrender#3720 * [x] gobwas/influent.rs#22 * [ ] https://bugzilla.mozilla.org/show_bug.cgi?id=1568540 - [x] seanmonstar/warp#260 - [ ] abonander/multipart#121 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23838) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Aug 17, 2019
Update the url crate to 2.0 Blocked on: * [x] housleyjk/ws-rs#283 + undoing corresponding `[patch.crates-io]` entry Soft-blocked on: (we could add to the crate duplication allow-list instead) * [x] ~rust-windowing/winit#1066 - [x] rust-windowing/winit#1076 * [x] servo/media#288 * [ ] servo/webrender#3720 * [x] gobwas/influent.rs#22 * [ ] https://bugzilla.mozilla.org/show_bug.cgi?id=1568540 - [x] seanmonstar/warp#260 - [ ] abonander/multipart#121 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23838) <!-- Reviewable:end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.