Fix minor issues in e2e-tests-latest-eventing.sh #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the tests to verify the correct number and names of knative eventing deployments. The test tag postupgrade is added, marking the tests to run after upgrade to the latest HEAD of operator, with the latest generated manifest of knative eventing.
aliok
commented
Feb 7, 2020
|
|
||
| OPERATOR_DIR=$(dirname $0)/.. | ||
| # inherited from vendor/knative.dev/test-infra/scripts/library.sh | ||
| declare -A IS_PROW |
Author
There was a problem hiding this comment.
this is to be used later. it is inherited from the library.sh in test-infra
aliok
commented
Feb 7, 2020
| # inherited from vendor/knative.dev/test-infra/scripts/library.sh | ||
| declare -A IS_PROW | ||
|
|
||
| OPERATOR_DIR=$(cd $(dirname "$0")/.. && pwd) |
Author
There was a problem hiding this comment.
Changed
OPERATOR_DIR=$(dirname $0)/.. to
OPERATOR_DIR=$(cd $(dirname "$0")/.. && pwd)
.
First one results in a relative path and when we cd into eventing folder later in the script, cding back with that relative path goes to another directory relative to eventing, not eventing-operator.
Second one results in an absolute path and cding to that path always works.
aliok
commented
Feb 7, 2020
Comment on lines
+78
to
+82
| if (( IS_PROW )); then | ||
| ko resolve -P -f ${config}/ | "${LABEL_YAML_CMD[@]}" > ${yaml} | ||
| else | ||
| ko resolve -f ${config}/ | "${LABEL_YAML_CMD[@]}" > ${yaml} | ||
| fi |
Author
There was a problem hiding this comment.
Don't use -P when the script is running local. Can't push to Docker when image paths are preserved.
Author
There was a problem hiding this comment.
Well, I switched to Quay and this problem is gone.
houshengbo
force-pushed
the
upgrade-test
branch
6 times, most recently
from
388f348 to
43d7852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements. Comments inline