Skip to content
This repository was archived by the owner on Jul 14, 2022. It is now read-only.

Comments

Support for Ctypes , HTML and XML responses#9

Merged
athul merged 9 commits intomasterfrom
ctypes
Feb 13, 2020
Merged

Support for Ctypes , HTML and XML responses#9
athul merged 9 commits intomasterfrom
ctypes

Conversation

@athul
Copy link
Contributor

@athul athul commented Feb 11, 2020

This PR will close #6 and will make it easier to add the -c/--ctypes flag with abbreviations like
html : text/html
js : application/json,
xml : application/xml
plain : text/plain
Making it easier to input the whole Request with Content Types

@athul athul requested a review from liyasthomas February 12, 2020 12:51
@athul
Copy link
Contributor Author

athul commented Feb 12, 2020

Hey @gbmor since I don't know anyone else to ask out for a review. It would be great if you could review this if you've got time.

@athul athul removed the request for review from liyasthomas February 12, 2020 12:53
Copy link
Contributor

@gbmor gbmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retbody is never assigned if the response is text/plain. Causes pwcli to exit without displaying the response. These suggested changes on fns.go display the body of the response.

@gbmor gbmor mentioned this pull request Feb 12, 2020
@athul
Copy link
Contributor Author

athul commented Feb 13, 2020

Thanks for the Review and Feedback @gbmor . I'll add you to the repository and I'm merging this

@athul athul merged commit 6f797bf into master Feb 13, 2020
@gbmor
Copy link
Contributor

gbmor commented Feb 13, 2020

Any time!

@athul athul deleted the ctypes branch September 3, 2020 05:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Support for text/html,xml responses

2 participants