Skip to content
This repository was archived by the owner on Jul 14, 2022. It is now read-only.

Comments

Added arm64 support for all OS fixes issue #46#48

Closed
ashique-perumbavoor wants to merge 1 commit intohoppscotch:masterfrom
ashique-perumbavoor:arm64Support
Closed

Added arm64 support for all OS fixes issue #46#48
ashique-perumbavoor wants to merge 1 commit intohoppscotch:masterfrom
ashique-perumbavoor:arm64Support

Conversation

@ashique-perumbavoor
Copy link
Contributor

@ashique-perumbavoor ashique-perumbavoor commented Dec 30, 2021

I have also added targets option as below:

    targets:
      - linux_amd64
      - linux_arm64
      - linux_386
      - windows_amd64
      - windows_arm64
      - windows_386
      - darwin_amd64
      - darwin_arm64

Removing the unwanted os configuration will stop making it's binaries

@ashique-perumbavoor ashique-perumbavoor changed the title Added arm64 support for all OS Added arm64 support for all OS #46 Dec 30, 2021
@ashique-perumbavoor ashique-perumbavoor changed the title Added arm64 support for all OS #46 Added arm64 support for all OS Dec 30, 2021
@ashique-perumbavoor ashique-perumbavoor changed the title Added arm64 support for all OS Added arm64 support for all OS fixes #46 Dec 30, 2021
@ashique-perumbavoor ashique-perumbavoor changed the title Added arm64 support for all OS fixes #46 Added arm64 support for all OS fixes issue #46 Dec 30, 2021
@liyasthomas liyasthomas requested a review from athul December 30, 2021 10:17
@athul
Copy link
Contributor

athul commented Jan 2, 2022

Hey, sorry for the late comment. You should also update the RELEASE_BUILDS variable in the env key of the yml file. Also I wanted to switch the whole build from travis to GitHub actions. If you could do that too, it would be a lot easier

athul
athul suggested changes Jan 2, 2022
View reviewed changes
Copy link
Contributor

@athul athul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the PR comment

@ashique-perumbavoor ashique-perumbavoor marked this pull request as draft January 2, 2022 13:26
@ashique-perumbavoor ashique-perumbavoor mentioned this pull request Jan 19, 2022
Closed
@BRO3886
Copy link
Contributor

BRO3886 commented Jan 22, 2022

Hey, sorry for the late comment. You should also update the RELEASE_BUILDS variable in the env key of the yml file. Also I wanted to switch the whole build from travis to GitHub actions. If you could do that too, it would be a lot easier

@athul what do you want to add on RELEASE_BUILDS env?

This was referenced Jan 22, 2022
Closed
Merged
@athul
Copy link
Contributor

athul commented Feb 1, 2022

I guess this can be closed due to #49

@athul athul closed this Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@athul athul athul requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@athul athul

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashique-perumbavoor @athul @BRO3886