@@ -4,6 +4,7 @@ import { chmodSync, rmSync, statSync, symlinkSync } from 'node:fs'
44import path from 'node:path'
55import { serveStatic } from './../src/serve-static'
66import { createAdaptorServer } from './../src/server'
7+ import { requestServer } from './helpers/request'
78
89describe ( 'Serve Static Middleware' , ( ) => {
910 const app = new Hono < {
@@ -67,6 +68,21 @@ describe('Serve Static Middleware', () => {
6768
6869 const server = createAdaptorServer ( app )
6970
71+ beforeAll (
72+ ( ) =>
73+ new Promise < void > ( ( resolve , reject ) => {
74+ server . once ( 'error' , reject )
75+ server . listen ( 0 , '127.0.0.1' , resolve )
76+ } )
77+ )
78+
79+ afterAll (
80+ ( ) =>
81+ new Promise < void > ( ( resolve , reject ) => {
82+ server . close ( ( error ) => ( error ? reject ( error ) : resolve ( ) ) )
83+ } )
84+ )
85+
7086 it ( 'Should return index.html' , async ( ) => {
7187 const res = await request ( server ) . get ( '/static/' )
7288 expect ( res . status ) . toBe ( 200 )
@@ -271,7 +287,7 @@ describe('Serve Static Middleware', () => {
271287 } )
272288
273289 it ( 'Should handle double dots in URL' , async ( ) => {
274- const res = await request ( server ) . get ( ' /static/../secret.txt')
290+ const res = await requestServer ( server , { method : 'GET' , path : ' /static/../secret.txt' } )
275291 expect ( res . status ) . toBe ( 404 )
276292 } )
277293
@@ -428,18 +444,39 @@ describe('Serve Static Middleware', () => {
428444 const server = createAdaptorServer ( app )
429445 app . use ( '/static/*' , serveStatic ( { root : './test/assets' } ) )
430446
447+ beforeAll (
448+ ( ) =>
449+ new Promise < void > ( ( resolve , reject ) => {
450+ server . once ( 'error' , reject )
451+ server . listen ( 0 , '127.0.0.1' , resolve )
452+ } )
453+ )
454+
455+ afterAll (
456+ ( ) =>
457+ new Promise < void > ( ( resolve , reject ) => {
458+ server . close ( ( error ) => ( error ? reject ( error ) : resolve ( ) ) )
459+ } )
460+ )
461+
431462 it ( 'Should prevent path traversal attacks with double dots' , async ( ) => {
432- const res = await request ( server ) . get ( ' /static/../secret.txt')
463+ const res = await requestServer ( server , { method : 'GET' , path : ' /static/../secret.txt' } )
433464 expect ( res . status ) . toBe ( 404 )
434465 } )
435466
436467 it ( 'Should prevent path traversal attacks with multiple levels' , async ( ) => {
437- const res = await request ( server ) . get ( '/static/../../package.json' )
468+ const res = await requestServer ( server , {
469+ method : 'GET' ,
470+ path : '/static/../../package.json' ,
471+ } )
438472 expect ( res . status ) . toBe ( 404 )
439473 } )
440474
441475 it ( 'Should prevent path traversal attacks with mixed separators' , async ( ) => {
442- const res = await request ( server ) . get ( '/static/..\\..\\package.json' )
476+ const res = await requestServer ( server , {
477+ method : 'GET' ,
478+ path : '/static/..\\..\\package.json' ,
479+ } )
443480 expect ( res . status ) . toBe ( 404 )
444481 } )
445482
0 commit comments