Summary
serveStatic has an opt-in option, allowPercentInPath, for serving files whose names contain a literal %. With it enabled, the check added for GHSA-5r4p-p66f-jhc7 that rejects a path containing % is skipped, and the path is decoded a second time. A crafted request can be routed as one path and served as another, so middleware mounted on a static prefix does not run for a file under that prefix.
Details
Hono decodes the request path once before routing. With a malformed percent-encoded sequence, that decode leaves part of the path encoded, the router matches the encoded form, and the second decode in serveStatic resolves the real directory. The option skipped the check without limiting what the second decode may change.
serveStatic now accepts a path that still contains % only when the second decode changes nothing except %25, the escape for a literal %. Anything else is treated as not found. File names such as 100%.txt keep working. The file is still resolved inside the configured root; this is not a traversal outside it.
Impact
An unauthenticated attacker may reach static files without the middleware on their prefix running, for example an authentication check. This affects applications that set allowPercentInPath: true and mount middleware on part of the directory served by serveStatic. The default configuration was fixed in 4.13.11 and is not affected.
Summary
serveStatichas an opt-in option,allowPercentInPath, for serving files whose names contain a literal%. With it enabled, the check added for GHSA-5r4p-p66f-jhc7 that rejects a path containing%is skipped, and the path is decoded a second time. A crafted request can be routed as one path and served as another, so middleware mounted on a static prefix does not run for a file under that prefix.Details
Hono decodes the request path once before routing. With a malformed percent-encoded sequence, that decode leaves part of the path encoded, the router matches the encoded form, and the second decode in
serveStaticresolves the real directory. The option skipped the check without limiting what the second decode may change.serveStaticnow accepts a path that still contains%only when the second decode changes nothing except%25, the escape for a literal%. Anything else is treated as not found. File names such as100%.txtkeep working. The file is still resolved inside the configured root; this is not a traversal outside it.Impact
An unauthenticated attacker may reach static files without the middleware on their prefix running, for example an authentication check. This affects applications that set
allowPercentInPath: trueand mount middleware on part of the directory served byserveStatic. The default configuration was fixed in 4.13.11 and is not affected.