Skip to content

`serveStatic` with `allowPercentInPath` still decodes the path a second time, bypassing middleware on static paths

Moderate
yusukebe published GHSA-74fm-fwc7-3fwp Nov 11, 2026

Package

npm hono (npm)

Affected versions

>= 4.13.11, <= 4.13.17

Patched versions

4.13.18

Description

Summary

serveStatic has an opt-in option, allowPercentInPath, for serving files whose names contain a literal %. With it enabled, the check added for GHSA-5r4p-p66f-jhc7 that rejects a path containing % is skipped, and the path is decoded a second time. A crafted request can be routed as one path and served as another, so middleware mounted on a static prefix does not run for a file under that prefix.

Details

Hono decodes the request path once before routing. With a malformed percent-encoded sequence, that decode leaves part of the path encoded, the router matches the encoded form, and the second decode in serveStatic resolves the real directory. The option skipped the check without limiting what the second decode may change.

serveStatic now accepts a path that still contains % only when the second decode changes nothing except %25, the escape for a literal %. Anything else is treated as not found. File names such as 100%.txt keep working. The file is still resolved inside the configured root; this is not a traversal outside it.

Impact

An unauthenticated attacker may reach static files without the middleware on their prefix running, for example an authentication check. This affects applications that set allowPercentInPath: true and mount middleware on part of the directory served by serveStatic. The default configuration was fixed in 4.13.11 and is not affected.

Severity

Moderate

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
Low
Integrity
None
Availability
None

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N

CVE ID

No known CVE

Weaknesses

Double Decoding of the Same Data

The product decodes the same input twice. Learn more on MITRE.

Credits