Repository navigation
fix(jsx): add the CSP nonce to all scripts generated by ErrorBoundary - #5430
Merged
Merged
Conversation
honojs#4216 added `scriptNonce` support via `StreamingContext`, but two of the three inline scripts ErrorBoundary emits while streaming were left without the nonce: - the script that swaps in the fallback when a child rejects during streaming - the cleanup script emitted after all nested Suspense boundaries resolve Under a nonce-based CSP these scripts are blocked, so the fallback is never shown and the boundary markers are never removed. The existing "with StreamingContext" test was asserting the nonce-less cleanup script; it now expects the nonce, and a test for the error path is added.
yusukebe
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4216 added
scriptNoncesupport viaStreamingContext, but two of the three inline scriptsErrorBoundaryemits while streaming were left without the nonce:Suspenseboundaries resolveUnder a nonce-based CSP these scripts are blocked, so the fallback is never shown and the boundary markers are never removed.
The existing "with StreamingContext" test was asserting the nonce-less cleanup script; it now expects the nonce, and a test for the error path is added. Both tests fail without this change.
Related: #4205, #4216.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code